Skip unrelated files when using `git archive` #1287

pull hebasto wants to merge 1 commits into bitcoin-core:master from hebasto:230421-archive changing 1 files +5 −0

hebasto commented at 10:07 PM on April 21, 2023: member

An option for #1175:

$ git fetch origin pull/1287/head
$ git archive --output=libsecp256k1-PR1287.tar.gz FETCH_HEAD 
$ sha256sum libsecp256k1-PR1287.tar.gz 
6e6fd21afd935e572b138258f782fed60bb11fa88aa51a9866f10cca5d25c39c  libsecp256k1-PR1287.tar.gz
$ git archive --output=libsecp256k1-PR1287.zip FETCH_HEAD 
$ sha256sum libsecp256k1-PR1287.zip 
e108fc4902502640eee2cf4bb69501a494904c4dcd0763c072cc4acaed565861  libsecp256k1-PR1287.zip

Skip unrelated files when using `git archive` 3f483e4cfd
hebasto cross-referenced this on Apr 21, 2023 from issue release: Release tarballs? How to sign releases? by real-or-random

jonasnick commented at 8:21 AM on April 23, 2023: contributor

In what sense are these files unrelated? Is it worth maintaining a list of files in .gitattributes that are "unrelated"?

Fwiw git archive is not deterministic:

❯ git fetch origin pull/1287/head && git archive --output=libsecp256k1-PR1287.tar.gz FETCH_HEAD && sha256sum libsecp256k1-PR1287.tar.gz
From github.com:bitcoin-core/secp256k1
 * branch              refs/pull/1287/head -> FETCH_HEAD
5df771480968b3ff3df53c2808284e855912f037fa2c206b35205ae856e2aa52  libsecp256k1-PR1287.tar.gz
❯ git archive --output=libsecp256k1-PR1287.zip FETCH_HEAD  && sha256sum libsecp256k1-PR1287.zip
7d7167119528c18710f8f5191e2a574405f016f17a7b520a970aca22afa8778e  libsecp256k1-PR1287.zip

hebasto commented at 8:47 AM on April 23, 2023: member

In what sense are these files unrelated? Is it worth maintaining a list of files in .gitattributes that are "unrelated"?

From #1175#issue-1492956877:

It's a bit silly to not include files like .gitignore and .cirrus.yml. I mean this is for devs of the library, you would want to have these files.
hebasto commented at 9:53 AM on April 23, 2023: member

Fwiw git archive is not deterministic:

Hmm, that's unexpected (

git archive uses the passed commit time as the modification time of each file in the archive. And gzip is deterministic as well.

What is the source of non-determinism in your opinion?
real-or-random commented at 7:01 AM on April 24, 2023: contributor

From #1175 (comment):

It's a bit silly to not include files like .gitignore and .cirrus.yml. I mean this is for devs of the library, you would want to have these files.

Maybe you just got my comment the wrong way around? I said, "it's silly NOT to include (...)", so I'm arguing to include the files in the archive! I think they belong to the repo. Even as a local developer without git, you could potentially be interested in what is run on CI or what the maintainers believe should be in .gitignore (and other tools such as ripgrep use .gitignore, etc...) Happy to hear arguments for the other direction, of course. :)
hebasto commented at 7:03 AM on April 24, 2023: member

My bad! Sorry.
real-or-random commented at 7:04 AM on April 24, 2023: contributor

My bad! Sorry.

No worries. :)
real-or-random closed this on Apr 25, 2023
hebasto deleted the branch on Apr 29, 2023

Contributors

hebasto

jonasnick

real-or-random

Linked (view graph)

#1175 release: Release tarballs? How to sign releases?