Remove randomness tests #1298

pull sipa wants to merge 3 commits into bitcoin-core:master from sipa:202306_no_test_xoro changing 2 files +49 −124

sipa commented at 4:18 PM on May 8, 2023: contributor
Our RNG has been replaced with Xoshiro256++, a well-analyzed RNG. Our unit tests should not be resposible for verifying its statistical qualities.

TODO:
- Add static test vectors

Remove randomness tests

Our RNG has been replaced with Xoshiro256++, a well-analyzed RNG. Our
unit tests should not be resposible for verifying its statistical
qualities.

723e8ca8f7

real-or-random commented at 4:28 PM on May 8, 2023: contributor

Concept ACK
Add static test vector for Xoshiro256++ fb5bfa4eed
real-or-random force-pushed on May 9, 2023
Simplify test PRNG implementation 6ec3731e8c
real-or-random added the label assurance on May 10, 2023
real-or-random cross-referenced this on Jul 17, 2023 from issue subtree: update libsecp256k1 to latest master by fanquake
jonasnick commented at 8:17 PM on July 17, 2023: contributor

Concept ACK
sipa marked this as ready for review on Jul 18, 2023
real-or-random approved
real-or-random commented at 7:59 AM on July 18, 2023: contributor

utACK 6ec3731e8c53658fcf68634c81bb1e47cad791ad
jonasnick approved
jonasnick commented at 2:02 PM on July 18, 2023: contributor

ACK 6ec3731e8c53658fcf68634c81bb1e47cad791ad
jonasnick merged this on Jul 18, 2023
jonasnick closed this on Jul 18, 2023
fanquake referenced this in commit ff061fde18 on Jul 18, 2023
hebasto referenced this in commit 270d2b37b8 on Jul 21, 2023
jonasnick cross-referenced this on Jul 27, 2023 from issue Upstream PRs 1357, 1345, 1358, 1368, 1369, 1323, 1364, 1370, 1367, 1344, 1371, 1363, 1340, 1366, 1313, 1378, 1298, 1382, 1383, 1384, 1386 by jonasnick

Contributors

Labels