Avoid normalize conditional on VERIFY #1300

pull sipa wants to merge 1 commits into bitcoin-core:master from sipa:202306_cleanup_normalize changing 2 files +3 −4
  1. sipa commented at 5:53 PM on May 9, 2023: contributor

    In the old code, secp256k1_gej_rescale requires a normalized input in VERIFY mode, but not otherwise. Its requirements shouldn't depend on this mode being enabled or not.

  2. real-or-random approved
  3. real-or-random commented at 1:43 PM on May 10, 2023: contributor

    utACK https://github.com/bitcoin-core/secp256k1/pull/1300/commits/533c8f2f353f3f5bbb650e1175bc67d70637c8a8 I've also verified that the loop in secp256k1_ecmult_strauss_wnaf holds up the invariant that the magnitude of Z is 1, even with the normalization removed

  4. real-or-random commented at 7:39 AM on May 11, 2023: contributor

    needs rebase ...

  5. Avoid normalize conditional on VERIFY 97c63b9039
  6. sipa force-pushed on May 11, 2023
  7. sipa commented at 7:42 AM on May 11, 2023: contributor

    Rebased.

  8. real-or-random approved
  9. real-or-random commented at 7:49 AM on May 11, 2023: contributor

    utACK 97c63b90390b0b11a5d3530b03855ec9cc0de343 I've also verified that the loop in secp256k1_ecmult_strauss_wnaf holds up the invariant that the magnitude of Z is 1, even with the normalization removed

  10. jonasnick commented at 12:28 PM on May 11, 2023: contributor

    ACK 97c63b90390b0b11a5d3530b03855ec9cc0de343

  11. sipa merged this on May 11, 2023
  12. sipa closed this on May 11, 2023
  13. sipa referenced this in commit b4eb644b6c on May 12, 2023
  14. hebasto referenced this in commit 49c52ea2b1 on May 13, 2023
  15. vmta referenced this in commit e1120c94a1 on Jun 4, 2023
  16. sipa referenced this in commit 901336eee7 on Jun 21, 2023
  17. vmta referenced this in commit 8f03457eed on Jul 1, 2023
  18. jonasnick cross-referenced this on Jul 24, 2023 from issue Upstream PRs 1268, 1276, 1267, 1265, 1230, 1279, 1273, 1263, 1231, 1285, 1283, 1205, 1286, 1275, 1234, 1239, 1240, 1284, 1277, 1289, 1270, 1296, 1301, 1299, 1066, 1300, 1292, 1305, 1303, 1133, 1306, 1207, 1304, 1307, 1311, 1309, 1312 by jonasnick
Contributors
sipareal-or-randomjonasnick
github-metadata-mirror

This is a metadata mirror of the GitHub repository bitcoin-core/secp256k1. This site is not affiliated with GitHub. Content is generated from a GitHub metadata backup.
generated: 2026-04-14 11:15 UTC
This site is hosted by @0xB10C
More mirrored repositories can be found on mirror.b10c.me