Remove unused scratch space from API #1305

1. 
   jonasnick commented at 2:05 PM on May 11, 2023: contributor

   Not sure if we want the typedef and secp256k1_scratch_space_{create,destroy} but if we don't keep them then this PR will be a rather large diff.

2. Remove unused scratch space from API 712e7f8722
3. jonasnick added this to the milestone 0.3.2 (or 0.4.0) on May 11, 2023
4. jonasnick marked this as ready for review on May 11, 2023
5. real-or-random approved
6. 
   real-or-random commented at 2:41 PM on May 11, 2023: contributor

   utACK 712e7f8722eba5dec2bc6b37d75aadeb6f6e633b

7. 
   jonasnick commented at 2:42 PM on May 11, 2023: contributor

   I should have mentioned the rationale. The idea is to remove the scratch space from the API is because it's unused right now. Maybe we bring it back (in some form) at some point (see #1302).

8. 
   sipa commented at 4:00 PM on May 11, 2023: contributor

   ACK 712e7f8722eba5dec2bc6b37d75aadeb6f6e633b

   See my rationale in #1302 (comment)

9. 
   real-or-random commented at 4:01 PM on May 11, 2023: contributor

   cc @apoelstra

10. real-or-random merged this on May 11, 2023
11. real-or-random closed this on May 11, 2023

    ---

12. real-or-random added the label needs-changelog on May 11, 2023
13. apoelstra approved
14. 
    apoelstra commented at 5:03 PM on May 11, 2023: contributor

    ACK 712e7f8722eba5dec2bc6b37d75aadeb6f6e633b

15. sipa referenced this in commit b4eb644b6c on May 12, 2023
16. real-or-random referenced this in commit 9f41327c39 on May 12, 2023
17. real-or-random referenced this in commit 977eaf4af0 on May 12, 2023
18. hebasto referenced this in commit 49c52ea2b1 on May 13, 2023
19. real-or-random removed the label needs-changelog on May 13, 2023
20. vmta referenced this in commit e1120c94a1 on Jun 4, 2023
21. sipa referenced this in commit 901336eee7 on Jun 21, 2023
22. vmta referenced this in commit 8f03457eed on Jul 1, 2023
23. delta1 referenced this in commit 3f32c20932 on Aug 8, 2023
24. delta1 referenced this in commit 31ac0c1081 on Aug 31, 2023
25. janus referenced this in commit c4348d88db on Sep 11, 2023
26. real-or-random referenced this in commit 1fae76f50c on Oct 21, 2024
27. div72 referenced this in commit af627d47c3 on Apr 12, 2025
28. str4d referenced this in commit 5a6bf5f178 on Jun 4, 2025
29. bitcoin-core deleted a comment on Jun 12, 2025

Contributors

jonasnickreal-or-randomsipaapoelstra

Milestone
0.4.0