doc: minor ellswift.md updates #1363

pull stratospher wants to merge 1 commits into bitcoin-core:master from stratospher:ellswift_doc changing 2 files +3 −3
  1. stratospher commented at 8:10 pm on June 27, 2023: contributor
  2. real-or-random added the label documentation on Jun 27, 2023
  3. real-or-random requested review from sipa on Jul 3, 2023
  4. in doc/ellswift.md:445 in 60fe6b2822 outdated
    441@@ -442,7 +442,7 @@ And encoding would be done using a $G_{c,u}(x, y)$ function defined as:
    442   * If $c = 3$ and $r = 0$, return $\bot.$
    443   * Let $v = (r/s - u)/2.$
    444 * Let $w = \sqrt{s}$; return $\bot$ if not square.
    445-* Let $w' = w$ if $sign(w/2) = sign(y)$; $-w$ otherwise.
    446+* Let $w' = w$ if $sign(w) = sign(y)$; $-w$ otherwise.
    


    sipa commented at 5:42 pm on July 3, 2023:
    This change is not correct. The technique suggested in this section is to use the sign of $y$ to encode the sign of $Y$. $w$ and $Y$ are not the same however, so we need to correct for that.

    stratospher commented at 2:58 pm on July 5, 2023:
    oh! makes sense.
  5. sipa commented at 2:31 pm on July 5, 2023: contributor
    ACK the changes except the one I pointed out above.
  6. doc: minor ellswift.md updates c7d900ffd1
  7. stratospher force-pushed on Jul 5, 2023
  8. sipa commented at 4:09 pm on July 5, 2023: contributor
    ACK c7d900ffd18e88076920d4cd13fcdca210acd903
  9. real-or-random approved
  10. real-or-random commented at 4:16 pm on July 5, 2023: contributor
    ACK c7d900ffd18e88076920d4cd13fcdca210acd903
  11. real-or-random merged this on Jul 6, 2023
  12. real-or-random closed this on Jul 6, 2023

  13. fanquake referenced this in commit 56c05c5ec4 on Jul 17, 2023
  14. fanquake referenced this in commit ff061fde18 on Jul 18, 2023
  15. hebasto referenced this in commit 270d2b37b8 on Jul 21, 2023

github-metadata-mirror

This is a metadata mirror of the GitHub repository bitcoin-core/secp256k1. This site is not affiliated with GitHub. Content is generated from a GitHub metadata backup.
generated: 2024-10-30 01:15 UTC

This site is hosted by @0xB10C
More mirrored repositories can be found on mirror.b10c.me