ci, doc: Document required actions #1408

pull hebasto wants to merge 1 commits into bitcoin-core:master from hebasto:230821-gha-doc changing 1 files +7 −0

hebasto commented at 9:50 pm on August 21, 2023: member

Suggested in https://github.com/bitcoin/bitcoin/pull/28173#pullrequestreview-1587098202:

I wonder if it makes sense to document the required permissions inside the file?
ci, doc: Document required actions 1d29b8426a
real-or-random commented at 8:53 am on August 22, 2023: contributor

Hm, isn’t this clear from reading the files? I think that means that adding a comment is mostly an additional maintenance burden because we need to keep it up-to-date (and no tool complains if we forget).

Also, the required permissions are not canonical. You could also allow any action, or pin the actions to specific commit ids. All of these options would work.
real-or-random added the label ci on Aug 22, 2023
hebasto closed this on Aug 22, 2023

Labels
ci