v0.4.1 release aftermath #1468

pull real-or-random wants to merge 5 commits into bitcoin-core:master from real-or-random:202312-release-aftermath changing 2 files +51 −48

real-or-random commented at 4:32 PM on December 21, 2023: contributor

No description provided.
real-or-random added the label meta/development on Dec 21, 2023
real-or-random added the label release on Dec 21, 2023
release process: Run sanity checks on release PR 429d21dc79
release process: Add email step e7053d065b
real-or-random force-pushed on Dec 21, 2023
real-or-random commented at 4:35 PM on December 21, 2023: contributor

cc @hebasto
in tools/check-abi.sh:6 in d6274ea331 outdated
```
   2 | @@ -3,7 +3,7 @@
   3 |  set -eu
   4 |  
   5 |  default_base_version="$(git describe --match "v*.*.*" --abbrev=0)"
   6 | -default_new_version="master"
   7 | +default_new_version="HEAD"
```
hebasto commented at 6:00 PM on December 21, 2023:

default_new_version="$(git rev-parse HEAD)"

Otherwise, the HEAD will be modified, which is not what we want.
real-or-random commented at 12:00 AM on January 9, 2024:

I'm not entirely sure what you meant here, but I believe I fixed it
hebasto commented at 6:04 PM on December 21, 2023: member

Is it a proper moment to unify tag related steps in the "Regular release" and "Maintenance release" sections?

Regular release: 3. After the PR is merged, tag the commit and push it:

Maintenance release: 4. After the PRs are merged, update the release branch and tag the commit: 5. Push tag:
jonasnick commented at 2:53 PM on January 3, 2024: contributor

ACK mod hebasto's comments
release process: Style and formatting nits 9fb7e2f156
check-abi: Default to HEAD for new version ad5f589a94
real-or-random force-pushed on Jan 9, 2024
real-or-random commented at 12:01 AM on January 9, 2024: contributor

Is it a proper moment to unify tag related steps in the "Regular release" and "Maintenance release" sections?

Done. Ready for review again.
check-abi: Minor UI improvements b37fdb28ce
real-or-random force-pushed on Jan 9, 2024
hebasto commented at 7:20 PM on January 16, 2024: member

ACK b37fdb28ce373e359e4d3a9727693b724db31676.
jonasnick approved
jonasnick commented at 7:57 PM on January 16, 2024: contributor

ACK b37fdb28ce373e359e4d3a9727693b724db31676
jonasnick merged this on Jan 16, 2024
jonasnick closed this on Jan 16, 2024

Contributors

real-or-random

hebasto

jonasnick

Labels

meta/development release