include: make docs more consistent #1476
pull jonasnick wants to merge 3 commits into bitcoin-core:master from jonasnick:ctx-doc changing 8 files +62 −62-
jonasnick commented at 5:15 pm on January 4, 2024: contributor
-
include: remove obvious "cannot be NULL" doc e3f690015a
-
include: make doc about ctx more consistent
Replaces "ctx: a secp256k1 context object" with "ctx: pointer to a context object". Also removes the word "existing".
-
real-or-random commented at 5:29 pm on January 4, 2024: contributorWe often say “a pointer” (instead of just “pointer”) in other places, e.g., all other arguments of
secp256k1_ec_pubkey_serialize
. I mean, it doesn’t matter too much, but if the point of the PR is to get it consistent, perhaps we should also make this part consistent. -
real-or-random added the label refactor/smell on Jan 4, 2024
-
real-or-random added the label meta/development on Jan 4, 2024
-
jonasnick cross-referenced this on Jan 4, 2024 from issue Add an experimental schnorr signature adaptor module by ZhePang
-
real-or-random commented at 8:55 am on January 5, 2024: contributor
git grep -E ":[ ]+a pointer"
shows three more occurrences. (Well, wo of them are incontrib/lax_der_parsing.h
… Since we anyway converged from the version of this file in Core, I’d replace them too, but either way is good, I guess.)ACK mod this nit
-
include: in doc, remove article in front of "pointer" da7bc1b803
-
jonasnick force-pushed on Jan 6, 2024
-
real-or-random approved
-
real-or-random commented at 0:16 am on January 9, 2024: contributorACK da7bc1b803b14274bc1687514e5da6a3e1cd9765
-
real-or-random removed the label meta/development on Jan 9, 2024
-
real-or-random added the label user-documentation on Jan 9, 2024
-
sipa commented at 2:21 pm on January 9, 2024: contributorACK da7bc1b803b14274bc1687514e5da6a3e1cd9765
-
jonasnick merged this on Jan 9, 2024
-
jonasnick closed this on Jan 9, 2024
github-metadata-mirror
This is a metadata mirror of the GitHub repository bitcoin-core/secp256k1. This site is not affiliated with GitHub. Content is generated from a GitHub metadata backup.
generated: 2024-12-03 17:15 UTC
This is a metadata mirror of the GitHub repository bitcoin-core/secp256k1. This site is not affiliated with GitHub. Content is generated from a GitHub metadata backup.
generated: 2024-12-03 17:15 UTC
This site is hosted by @0xB10C
More mirrored repositories can be found on mirror.b10c.me
More mirrored repositories can be found on mirror.b10c.me