No description provided.
include: make docs more consistent #1476
pull jonasnick wants to merge 3 commits into bitcoin-core:master from jonasnick:ctx-doc changing 8 files +62 −62-
jonasnick commented at 5:15 PM on January 4, 2024: contributor
-
include: remove obvious "cannot be NULL" doc e3f690015a
-
aa3dd5280b
include: make doc about ctx more consistent
Replaces "ctx: a secp256k1 context object" with "ctx: pointer to a context object". Also removes the word "existing".
-
real-or-random commented at 5:29 PM on January 4, 2024: contributor
We often say "a pointer" (instead of just "pointer") in other places, e.g., all other arguments of
secp256k1_ec_pubkey_serialize. I mean, it doesn't matter too much, but if the point of the PR is to get it consistent, perhaps we should also make this part consistent. - real-or-random added the label refactor/smell on Jan 4, 2024
- real-or-random added the label meta/development on Jan 4, 2024
-
real-or-random commented at 8:55 AM on January 5, 2024: contributor
git grep -E ":[ ]+a pointer"shows three more occurrences. (Well, wo of them are incontrib/lax_der_parsing.h... Since we anyway converged from the version of this file in Core, I'd replace them too, but either way is good, I guess.)ACK mod this nit
-
include: in doc, remove article in front of "pointer" da7bc1b803
- jonasnick force-pushed on Jan 6, 2024
- real-or-random approved
-
real-or-random commented at 12:16 AM on January 9, 2024: contributor
ACK da7bc1b803b14274bc1687514e5da6a3e1cd9765
- real-or-random removed the label meta/development on Jan 9, 2024
- real-or-random added the label user-documentation on Jan 9, 2024
-
sipa commented at 2:21 PM on January 9, 2024: contributor
ACK da7bc1b803b14274bc1687514e5da6a3e1cd9765
- jonasnick merged this on Jan 9, 2024
- jonasnick closed this on Jan 9, 2024
- vmta referenced this in commit 9cc5271211 on Jan 15, 2024
- achow101 referenced this in commit 9d962e5e0d on Jan 15, 2024
- real-or-random referenced this in commit cbcc623292 on Jan 18, 2024
- real-or-random referenced this in commit 010f1fe0c3 on Jan 23, 2024
- real-or-random referenced this in commit c29f28e638 on Jan 23, 2024
- fjahr referenced this in commit d5f970e647 on Feb 25, 2024
- achow101 referenced this in commit edc3e9107b on Mar 20, 2024
- achow101 referenced this in commit b525369f8e on Mar 25, 2024
- achow101 referenced this in commit 2189d2f841 on Apr 1, 2024
- fanquake referenced this in commit 5354807b00 on Apr 4, 2024
- fanquake referenced this in commit 53eec53dca on Apr 4, 2024
- hebasto referenced this in commit b6de625950 on May 11, 2024
- janus referenced this in commit 939262869a on Jun 6, 2024
- delta1 referenced this in commit 6089844b3c on Apr 2, 2025
- div72 referenced this in commit af627d47c3 on Apr 12, 2025
- oskarszoon referenced this in commit 0d5c9260f4 on Jul 1, 2025
Contributors