ci: Add workaround for ASLR bug in sanitizers #1507

pull real-or-random wants to merge 2 commits into bitcoin-core:master from real-or-random:202403-clang-sanitizer-segfault-2 changing 2 files +6 −1

real-or-random commented at 4:20 PM on March 19, 2024: contributor

Fixes #1506.

This also adds the sanitizer env variables to our debug output as suggested in the same issue.
real-or-random added the label assurance on Mar 19, 2024
real-or-random added the label ci on Mar 19, 2024
real-or-random force-pushed on Mar 19, 2024

in .github/actions/run-in-docker-action/action.yml:40 in 05271c4373 outdated

  35 | @@ -36,6 +36,9 @@ runs:
  36 |          load: true
  37 |          cache-from: type=gha
  38 |  
  39 | +    - # Workaround for https://github.com/google/sanitizers/issues/1614 .
  40 | +      run: sysctl -w vm.mmap_rnd_bits=28

sipa commented at 4:56 PM on March 19, 2024:

The template is not valid. /home/runner/work/secp256k1/secp256k1/./.github/actions/run-in-docker-action/action.yml (Line: 40, Col: 7): Required property is missing: shell

real-or-random commented at 4:57 PM on March 19, 2024:

should be fixed by force-push

real-or-random force-pushed on Mar 19, 2024
sipa commented at 7:03 PM on March 19, 2024: contributor

The shell problem is resolved now, but the underlying issue seems unchanged.
maflcko commented at 8:10 PM on March 19, 2024: none

Yes, it is because of sysctl: permission denied on key "vm.mmap_rnd_bits", ignoring

See https://github.com/bitcoin-core/secp256k1/actions/runs/8347067930/job/22845907812?pr=1507#step:3:587
ci: Add workaround for ASLR bug in sanitizers
Fixes #1506.
84a93de4d2
ci: Add sanitizer env variables to debug output a5e8ab2484
real-or-random force-pushed on Mar 19, 2024
real-or-random commented at 10:54 PM on March 19, 2024: contributor

Ugh, yeah, sudo should help...
jonasnick approved
jonasnick commented at 9:00 AM on March 20, 2024: contributor

ACK a5e8ab248447864873eae9b00f94175594477d66
sipa commented at 12:22 PM on March 20, 2024: contributor

utACK a5e8ab248447864873eae9b00f94175594477d66
real-or-random merged this on Mar 20, 2024
real-or-random closed this on Mar 20, 2024

Contributors

Labels

Linked (view graph)

#1506 Clang sanitizer binaries segfault on CI