ci: Add workaround for ASLR bug in sanitizers #1507

pull real-or-random wants to merge 2 commits into bitcoin-core:master from real-or-random:202403-clang-sanitizer-segfault-2 changing 2 files +6 −1
  1. real-or-random commented at 4:20 pm on March 19, 2024: contributor

    Fixes #1506.

    This also adds the sanitizer env variables to our debug output as suggested in the same issue.

  2. real-or-random added the label assurance on Mar 19, 2024
  3. real-or-random added the label ci on Mar 19, 2024
  4. real-or-random force-pushed on Mar 19, 2024
  5. in .github/actions/run-in-docker-action/action.yml:40 in 05271c4373 outdated
    35@@ -36,6 +36,9 @@ runs:
    36         load: true
    37         cache-from: type=gha
    38 
    39+    - # Workaround for https://github.com/google/sanitizers/issues/1614 .
    40+      run: sysctl -w vm.mmap_rnd_bits=28
    


    sipa commented at 4:56 pm on March 19, 2024:
    0The template is not valid. /home/runner/work/secp256k1/secp256k1/./.github/actions/run-in-docker-action/action.yml (Line: 40, Col: 7): Required property is missing: shell
    

    real-or-random commented at 4:57 pm on March 19, 2024:
    should be fixed by force-push
  6. real-or-random force-pushed on Mar 19, 2024
  7. sipa commented at 7:03 pm on March 19, 2024: contributor
    The shell problem is resolved now, but the underlying issue seems unchanged.
  8. maflcko commented at 8:10 pm on March 19, 2024: none

    Yes, it is because of sysctl: permission denied on key "vm.mmap_rnd_bits", ignoring

    See https://github.com/bitcoin-core/secp256k1/actions/runs/8347067930/job/22845907812?pr=1507#step:3:587

  9. ci: Add workaround for ASLR bug in sanitizers
    Fixes #1506.
    84a93de4d2
  10. ci: Add sanitizer env variables to debug output a5e8ab2484
  11. real-or-random force-pushed on Mar 19, 2024
  12. real-or-random commented at 10:54 pm on March 19, 2024: contributor
    Ugh, yeah, sudo should help…
  13. jonasnick approved
  14. jonasnick commented at 9:00 am on March 20, 2024: contributor
    ACK a5e8ab248447864873eae9b00f94175594477d66
  15. sipa commented at 12:22 pm on March 20, 2024: contributor
    utACK a5e8ab248447864873eae9b00f94175594477d66
  16. real-or-random merged this on Mar 20, 2024
  17. real-or-random closed this on Mar 20, 2024


github-metadata-mirror

This is a metadata mirror of the GitHub repository bitcoin-core/secp256k1. This site is not affiliated with GitHub. Content is generated from a GitHub metadata backup.
generated: 2024-12-11 06:15 UTC

This site is hosted by @0xB10C
More mirrored repositories can be found on mirror.b10c.me