cmake: Fix `check_arm32_assembly` when using as subproject #1526

pull hebasto wants to merge 1 commits into bitcoin-core:master from hebasto:240507-project-dir changing 1 files +2 −2

hebasto commented at 11:40 AM on May 7, 2024: member

When integrating libsecpk1 in a downstream project like this:

set(SECP256K1_ASM arm32 CACHE STRING "" FORCE)
add_subdirectory(src/secp256k1)

it fails to configure:

CMake Error at /home/hebasto/git/bitcoin/build/check_arm32_assembly/CMakeFiles/CMakeTmp/CMakeLists.txt:21 (target_sources):
  Cannot find source file:

    /home/hebasto/git/bitcoin/cmake/source_arm32.s


CMake Error at /home/hebasto/git/bitcoin/build/check_arm32_assembly/CMakeFiles/CMakeTmp/CMakeLists.txt:20 (add_executable):
  No SOURCES given to target: cmTC_d0f0b


CMake Error at src/secp256k1/cmake/CheckArm32Assembly.cmake:2 (try_compile):
  Failed to generate test project build system.
Call Stack (most recent call first):
  src/secp256k1/CMakeLists.txt:127 (check_arm32_assembly)

This PR fixes this issue, which was overlooked in #1304.

cmake: Fix `check_arm32_assembly` when using as subproject 9f4c8cd730
hebasto commented at 11:41 AM on May 7, 2024: member

cc @real-or-random @theuni
real-or-random added the label build on May 7, 2024
real-or-random added the label bug on May 7, 2024
real-or-random approved
real-or-random commented at 11:44 AM on May 7, 2024: contributor

utACK 9f4c8cd730bba94f0c09cbef9b0cf9df44eb7b03

Yes, this makes sense according to the docs.
theuni approved
theuni commented at 5:14 PM on May 8, 2024: contributor

utACK 9f4c8cd730bba94f0c09cbef9b0cf9df44eb7b03
real-or-random merged this on May 9, 2024
real-or-random closed this on May 9, 2024
hebasto deleted the branch on May 9, 2024

Contributors

Labels

Linked (view graph)

#1304 build: Rename arm to arm32 and check if it's really supported