Is default `-Wl,--no-undefined` desired? #1556

issue hebasto opened this issue on June 28, 2024
  1. hebasto commented at 4:38 AM on June 28, 2024: member

    Consider the following diff:

    --- a/src/secp256k1.c
    +++ b/src/secp256k1.c
    @@ -765,7 +765,9 @@ int secp256k1_ec_pubkey_tweak_mul(const secp256k1_context* ctx, secp256k1_pubkey
         return ret;
     }
     
    +void undefined_function(void);
     int secp256k1_context_randomize(secp256k1_context* ctx, const unsigned char *seed32) {
    +    undefined_function();
         VERIFY_CHECK(ctx != NULL);
         ARG_CHECK(secp256k1_context_is_proper(ctx));
     
    

    It compiles fine:

    $ ./autogen.sh
    $ ./configure
    $ make libsecp256k1.la
    

    However, it should fail like that:

    $ ./autogen.sh
    $ ./configure LDFLAGS="-Wl,--no-undefined"
    $ make libsecp256k1.la
      CC       src/libsecp256k1_la-secp256k1.lo
      CC       src/libsecp256k1_precomputed_la-precomputed_ecmult.lo
      CC       src/libsecp256k1_precomputed_la-precomputed_ecmult_gen.lo
      CCLD     libsecp256k1_precomputed.la
      CCLD     libsecp256k1.la
    /usr/bin/ld: src/.libs/libsecp256k1_la-secp256k1.o: in function `secp256k1_context_randomize':
    /home/hebasto/git/secp256k1/secp256k1/src/secp256k1.c:770:(.text+0xee01): undefined reference to `undefined_function'
    collect2: error: ld returned 1 exit status
    make: *** [Makefile:1020: libsecp256k1.la] Error 1
    
  2. real-or-random added the label build on Jun 28, 2024
  3. real-or-random commented at 9:18 AM on June 28, 2024: contributor

    I think we want to check for undefined symbols, and -Wl,--no-undefined seems to be the canonical way of doing so.

    I assume one important exception is builds with external default callbacks, so we can't enable it in these cases.


github-metadata-mirror

This is a metadata mirror of the GitHub repository bitcoin-core/secp256k1. This site is not affiliated with GitHub. Content is generated from a GitHub metadata backup.
generated: 2026-04-22 18:15 UTC

This site is hosted by @0xB10C
More mirrored repositories can be found on mirror.b10c.me