fixes a few grammatical errors #1585

pull justinvforvendetta wants to merge 1 commits into bitcoin-core:master from justinvforvendetta:master changing 3 files +3 −3

justinvforvendetta commented at 7:50 PM on August 13, 2024: none

No description provided.
fixes a few grammatical errors ce51a71bec

in src/modinv32_impl.h:84 in ce51a71bec

  79 | @@ -80,7 +80,7 @@ static void secp256k1_modinv32_normalize_30(secp256k1_modinv32_signed30 *r, int3
  80 |      /* In a first step, add the modulus if the input is negative, and then negate if requested.
  81 |       * This brings r from range (-2*modulus,modulus) to range (-modulus,modulus). As all input
  82 |       * limbs are in range (-2^30,2^30), this cannot overflow an int32_t. Note that the right
  83 | -     * shifts below are signed sign-extending shifts (see assumptions.h for tests that that is
  84 | +     * shifts below are signed sign-extending shifts (see assumptions.h for tests that verify that is
  85 |       * indeed the behavior of the right shift operator). */

jonasnick commented at 1:35 PM on August 14, 2024:

Not a native speaker, but the current version seems easier to parse. Maybe "... for tests that this is indeed ...".

real-or-random commented at 3:06 PM on August 19, 2024:

NACK on this change. I think the current version on master is perfectly fine and readable, and so there's no reason to bother with it. Neither your first suggestion nor your updated suggestion seems natural to me. I feel that "that" should not be omitted here. If your grammar checker complains about a repeated word, then that's a false positive. (And I don't think Jonas' suggestion is an improvement either.)

real-or-random added the label refactor/smell on Aug 19, 2024
real-or-random added the label meta/development on Aug 19, 2024
justinvforvendetta closed this on Aug 19, 2024

Contributors

justinvforvendetta

jonasnick

real-or-random

Labels

refactor/smell meta/development