build: 45839th attempt to fix symbol visibility on Windows #1595

1. 
   real-or-random commented at 11:49 pm on August 24, 2024: contributor

   Fixes #1421. See code comments for rationale.

   Related meta-bug: #1181. This reminds me that we should move forward with #1359.

2. real-or-random added the label build on Aug 24, 2024
3. real-or-random force-pushed on Aug 25, 2024
4. real-or-random force-pushed on Aug 25, 2024
5. 
   fanquake commented at 10:13 am on September 6, 2024: member

   I can at least confirm that this “fixes” the output I was seeing in #1421. The most recent comment on the upstream GCC issue is not 100% clear to me.
6. 
   real-or-random commented at 7:16 pm on September 9, 2024: contributor

   The most recent comment on the upstream GCC issue is not 100% clear to me.

   Can you elaborate on which part is unclear?

   In any case, I could rephrase this such that it says it’s a GCC bug. When I wrote it, I wasn’t sure yet, but the upstream response seems to confirm that this is a bug.

7. 
   fanquake commented at 8:45 am on September 10, 2024: member

   I’ve re-read, and yes, it seems like the conclusion is that it is a GCC issue. I guess what is actually unclear is if/when anyone might fix it upstream.
8. include: Avoid visibility("default") on Windows

   Fixes #1421.

   447334cb06
9. real-or-random force-pushed on Sep 17, 2024
10. 
    real-or-random commented at 2:23 pm on September 17, 2024: contributor

    Okay. I’ve nevertheless rephrased the comment to make it (hopefully) clearer.

Contributors
real-or-random fanquake

Labels
build