examples: do not retry generating seckey randomness in musig #1616

1. 
   jonasnick commented at 7:33 am on October 13, 2024: contributor

   Follow-up to #1570.
2. jonasnick force-pushed on Oct 13, 2024
3. jonasnick force-pushed on Oct 14, 2024
4. jonasnick marked this as ready for review on Oct 14, 2024
5. real-or-random added the label user-documentation on Oct 14, 2024
6. real-or-random added the label refactor/smell on Oct 14, 2024
7. in include/secp256k1_extrakeys.h:164 in dad5db0428 outdated

   162- *           0: secret was invalid, try again with a different secret
   163+ *  See the documentation of `secp256k1_ec_seckey_verify` for more information
   164+ *  about the validity of secret keys.
   165+ *
   166+ *  Returns: 1: secret was valid
   167+ *           0: secret was invalid
   

   ---

   ---

   

   real-or-random commented at 8:43 am on October 14, 2024:

   nit: If we’re touching this, just say “secret key”? (And not that it matters, but it appears that we usually use present tense in these descriptions)

   0 *  Returns: 1: secret key is valid
   1 *           0: secret key is invalid
   

   ---

   

   jonasnick commented at 1:24 pm on October 14, 2024:

   Good idea, done.
8. real-or-random approved
9. 
   real-or-random commented at 8:45 am on October 14, 2024: contributor

   utACK dad5db04280eac99f6ac95f034058767512df90d
10. extrakeys: improve doc of keypair_create (don't suggest retry) 70b6be1834
11. examples: do not retry generating seckey randomness in musig e8908221a4
12. examples: make key generation doc consistent 5bab8f6d3c
13. jonasnick force-pushed on Oct 14, 2024
14. real-or-random approved
15. 
    real-or-random commented at 2:20 pm on October 14, 2024: contributor

    utACK 5bab8f6d3c4946f32bebd2a99b9975aa160ff794
16. theStack approved
17. 
    theStack commented at 3:22 pm on October 14, 2024: contributor

    ACK 5bab8f6d3c4946f32bebd2a99b9975aa160ff794
18. real-or-random merged this on Oct 14, 2024
19. real-or-random closed this on Oct 14, 2024

    ---

Contributors
jonasnick real-or-random theStack

Labels
user-documentation refactor/smell