examples: do not retry generating seckey randomness in musig #1616
pull jonasnick wants to merge 3 commits into bitcoin-core:master from jonasnick:example-musig-key changing 7 files +31 −27-
jonasnick commented at 7:33 am on October 13, 2024: contributorFollow-up to #1570.
-
jonasnick force-pushed on Oct 13, 2024
-
jonasnick force-pushed on Oct 14, 2024
-
jonasnick marked this as ready for review on Oct 14, 2024
-
real-or-random added the label user-documentation on Oct 14, 2024
-
real-or-random added the label refactor/smell on Oct 14, 2024
-
in include/secp256k1_extrakeys.h:164 in dad5db0428 outdated
162- * 0: secret was invalid, try again with a different secret 163+ * See the documentation of `secp256k1_ec_seckey_verify` for more information 164+ * about the validity of secret keys. 165+ * 166+ * Returns: 1: secret was valid 167+ * 0: secret was invalid
real-or-random commented at 8:43 am on October 14, 2024:nit: If we’re touching this, just say “secret key”? (And not that it matters, but it appears that we usually use present tense in these descriptions)
0 * Returns: 1: secret key is valid 1 * 0: secret key is invalid
jonasnick commented at 1:24 pm on October 14, 2024:Good idea, done.real-or-random approvedreal-or-random commented at 8:45 am on October 14, 2024: contributorutACK dad5db04280eac99f6ac95f034058767512df90dextrakeys: improve doc of keypair_create (don't suggest retry) 70b6be1834examples: do not retry generating seckey randomness in musig e8908221a4examples: make key generation doc consistent 5bab8f6d3cjonasnick force-pushed on Oct 14, 2024real-or-random approvedreal-or-random commented at 2:20 pm on October 14, 2024: contributorutACK 5bab8f6d3c4946f32bebd2a99b9975aa160ff794theStack approvedtheStack commented at 3:22 pm on October 14, 2024: contributorACK 5bab8f6d3c4946f32bebd2a99b9975aa160ff794real-or-random merged this on Oct 14, 2024real-or-random closed this on Oct 14, 2024
github-metadata-mirror
This is a metadata mirror of the GitHub repository bitcoin-core/secp256k1. This site is not affiliated with GitHub. Content is generated from a GitHub metadata backup.
generated: 2024-12-03 21:15 UTC
This is a metadata mirror of the GitHub repository bitcoin-core/secp256k1. This site is not affiliated with GitHub. Content is generated from a GitHub metadata backup.
generated: 2024-12-03 21:15 UTC
This site is hosted by @0xB10C
More mirrored repositories can be found on mirror.b10c.me
More mirrored repositories can be found on mirror.b10c.me