Closes #1627
Name public API structs #1628
pull achow101 wants to merge 1 commits into bitcoin-core:master from achow101:struct-name changing 5 files +12 −12-
achow101 commented at 5:57 PM on October 31, 2024: member
-
Name public API structs 694342fdb7
- real-or-random added the label feature on Nov 1, 2024
- real-or-random added the label refactor/smell on Nov 1, 2024
- real-or-random approved
-
real-or-random commented at 4:07 PM on November 1, 2024: contributor
utACK 694342fdb71722b31dd4b6bc7241b992fdf6f492
Fwiw, I had discussed this with @jonasnick because we were not sure if reusing the struct tag as the type name is okay also in C++. But while C++ has slightly different rules here, they're made so that compatibility to C is ensured, see https://stackoverflow.com/questions/1675351/typedef-struct-vs-struct-definitions
- jonasnick approved
-
jonasnick commented at 4:08 PM on November 1, 2024: contributor
ACK 694342fdb71722b31dd4b6bc7241b992fdf6f492
- real-or-random merged this on Nov 1, 2024
- real-or-random closed this on Nov 1, 2024
- real-or-random added the label needs-changelog on Nov 1, 2024
-
real-or-random commented at 4:13 PM on November 1, 2024: contributor
We may want to add a changelog entry for this PR. The change doesn't break anything, but it makes using the API more convenient, so users could be interested.
- achow101 referenced this in commit 378ca17fd1 on Nov 1, 2024
-
gatleas17 commented at 8:24 PM on November 2, 2024: none
ll
- achow101 referenced this in commit 2d46a89386 on Nov 4, 2024
- vmta referenced this in commit b5ae194ce5 on Nov 6, 2024
- vmta referenced this in commit 8999068421 on Nov 6, 2024
- Eunovo referenced this in commit 55a2f7a840 on Nov 12, 2024
- vmta referenced this in commit f40affbf6c on Nov 21, 2024
- vmta referenced this in commit cc8d145633 on Nov 22, 2024
- janus referenced this in commit a4b4239cb4 on Jan 19, 2025
- div72 referenced this in commit af627d47c3 on Apr 12, 2025
- fanquake removed the label needs-changelog on Jul 29, 2025
-
