Name public API structs #1628
pull achow101 wants to merge 1 commits into bitcoin-core:master from achow101:struct-name changing 5 files +12 −12-
achow101 commented at 5:57 pm on October 31, 2024: memberCloses #1627
-
Name public API structs 694342fdb7
-
real-or-random added the label feature on Nov 1, 2024
-
real-or-random added the label refactor/smell on Nov 1, 2024
-
real-or-random approved
-
real-or-random commented at 4:07 pm on November 1, 2024: contributor
utACK 694342fdb71722b31dd4b6bc7241b992fdf6f492
Fwiw, I had discussed this with @jonasnick because we were not sure if reusing the struct tag as the type name is okay also in C++. But while C++ has slightly different rules here, they’re made so that compatibility to C is ensured, see https://stackoverflow.com/questions/1675351/typedef-struct-vs-struct-definitions
-
jonasnick approved
-
jonasnick commented at 4:08 pm on November 1, 2024: contributorACK 694342fdb71722b31dd4b6bc7241b992fdf6f492
-
real-or-random merged this on Nov 1, 2024
-
real-or-random closed this on Nov 1, 2024
-
real-or-random added the label needs-changelog on Nov 1, 2024
-
real-or-random commented at 4:13 pm on November 1, 2024: contributorWe may want to add a changelog entry for this PR. The change doesn’t break anything, but it makes using the API more convenient, so users could be interested.
-
achow101 referenced this in commit 378ca17fd1 on Nov 1, 2024
-
gatleas17 commented at 8:24 pm on November 2, 2024: nonell
github-metadata-mirror
This is a metadata mirror of the GitHub repository bitcoin-core/secp256k1. This site is not affiliated with GitHub. Content is generated from a GitHub metadata backup.
generated: 2024-12-03 21:15 UTC
This is a metadata mirror of the GitHub repository bitcoin-core/secp256k1. This site is not affiliated with GitHub. Content is generated from a GitHub metadata backup.
generated: 2024-12-03 21:15 UTC
This site is hosted by @0xB10C
More mirrored repositories can be found on mirror.b10c.me
More mirrored repositories can be found on mirror.b10c.me