Fix some misspellings #1634

pull niooss-ledger wants to merge 1 commits into bitcoin-core:master from niooss-ledger:fix-some-misspellings changing 4 files +6 −6
  1. niooss-ledger commented at 3:50 pm on November 5, 2024: contributor

    Hello,

    Some files contained English misspellings or math issues (lamba instead of lambda), mainly in comments. Fixing them helps readability.

    By the way, the misspellings found in the Wycheproof test vector file were also reported upstream: https://github.com/C2SP/wycheproof/issues/124

  2. real-or-random commented at 6:24 pm on November 5, 2024: contributor

    Thanks! Concept ACK, obviously.

    By the way, the misspellings found in the Wycheproof test vector file were also reported upstream: C2SP/wycheproof#124

    Good, that’s probably the right path. And then I think it will be good then not to touch these files here. If you ask me, avoiding conflicts with the upstream is more important than fixing these typos. Could you modify the commit?

  3. real-or-random added the label refactor/smell on Nov 5, 2024
  4. Fix some misspellings
    Some files contained English misspellings or math issues (`lamba`
    instead of `lambda`).
    39705450eb
  5. niooss-ledger force-pushed on Nov 5, 2024
  6. niooss-ledger commented at 6:30 pm on November 5, 2024: contributor

    I think it will be good then not to touch these files here. If you ask me, avoiding conflicts with the upstream is more important than fixing these typos. Could you modify the commit?

    Ok, this works for me. I removed the changes related to Wycheproof test vectors.

  7. real-or-random approved
  8. real-or-random commented at 6:31 pm on November 5, 2024: contributor
    utACK 39705450ebcfc7a2a8be540c868da9d2c44900cb
  9. real-or-random merged this on Nov 5, 2024
  10. real-or-random closed this on Nov 5, 2024

  11. niooss-ledger deleted the branch on Nov 5, 2024

github-metadata-mirror

This is a metadata mirror of the GitHub repository bitcoin-core/secp256k1. This site is not affiliated with GitHub. Content is generated from a GitHub metadata backup.
generated: 2024-12-03 19:15 UTC

This site is hosted by @0xB10C
More mirrored repositories can be found on mirror.b10c.me