implemenation -> implementation
tests: update ecdsa_secp256k1_sha256_bitcoin_test.json #1638
pull eltociear wants to merge 1 commits into bitcoin-core:master from eltociear:patch-1 changing 1 files +1 −1-
eltociear commented at 12:18 PM on November 23, 2024: none
-
0823f20856
tests: update ecdsa_secp256k1_sha256_bitcoin_test.json
implemenation -> implementation
-
real-or-random commented at 9:40 PM on November 24, 2024: contributor
This has been fixed upstream in https://github.com/C2SP/wycheproof/pull/91 along with other changes. We should probably just reimport the file from upstream.
-
real-or-random commented at 10:16 PM on November 24, 2024: contributor
The only other change is https://github.com/C2SP/wycheproof/commit/875f85e2129d5287d94c7f589516b24813af9b61 , see https://github.com/C2SP/wycheproof/commits/master/testvectors_v1/ecdsa_secp256k1_sha256_bitcoin_test.json . @eltociear Can you include this in the PR here?
-
real-or-random commented at 10:18 PM on November 24, 2024: contributor
We should also update these lines then: https://github.com/bitcoin-core/secp256k1/blob/8deef00b33ca81202aca80fe0bcd9730f084fbd2/src/wycheproof/WYCHEPROOF_COPYING#L1-L4
- real-or-random added the label refactor/smell on Nov 24, 2024
Contributors
Labels