signaturelen not-validated. secp256k1_ecdsa_sign() will return 1 when no sig is returned #166

issue SergioDemianLerner opened this issue on December 16, 2014
  1. SergioDemianLerner commented at 7:45 PM on December 16, 2014: none

    In (see the note "MISSING"):

    int secp256k1_ecdsa_sign(const unsigned char *msg32, unsigned char *signature, int *signaturelen, const unsigned char *seckey, const unsigned char *nonce) {

    ..... if (ret) { ret = secp256k1_ecdsa_sig_sign(&sig, &sec, &msg, &non, NULL); } if (ret) { // MISSING "ret = " secp256k1_ecdsa_sig_serialize(signature, signaturelen, &sig); } ... return ret; }

  2. gmaxwell commented at 4:54 AM on January 11, 2015: contributor

    Fixed by #169

  3. gmaxwell closed this on Jan 11, 2015


github-metadata-mirror

This is a metadata mirror of the GitHub repository bitcoin-core/secp256k1. This site is not affiliated with GitHub. Content is generated from a GitHub metadata backup.
generated: 2026-04-14 14:15 UTC

This site is hosted by @0xB10C
More mirrored repositories can be found on mirror.b10c.me