cmake: Make `secp256k1_objs` inherit interface defines from `secp256k1` #1704

pull hebasto wants to merge 1 commits into bitcoin-core:master from hebasto:250718-win-static changing 1 files +2 −1
  1. hebasto commented at 4:39 PM on July 18, 2025: member

    This PR effectively adds -DSECP256K1_STATIC to usage requirements of secp256k1_objs on Windows, preventing LNK4217 linker warnings.

    I overlooked this issue while reviewing #1678.

  2. cmake: Make `secp256k1_objs` inherit interface defines from `secp256k1`
    This change effectively adds `-DSECP256K1_STATIC` to usage requirements
    of `secp256k1_objs` on Windows, preventing LNK4217 linker warnings.
    bf082221ff
  3. hebasto commented at 4:41 PM on July 18, 2025: member

    I overlooked this issue while reviewing #1678.

    It would be nice to have this included in 0.7.0, along with #1678.

  4. hebasto commented at 4:41 PM on July 18, 2025: member

    cc @theuni

  5. real-or-random added the label build on Jul 18, 2025
  6. real-or-random added the label refactor/smell on Jul 18, 2025
  7. real-or-random added this to the milestone 0.7.0 on Jul 18, 2025
  8. real-or-random approved
  9. real-or-random commented at 11:36 AM on July 21, 2025: contributor

    utACK bf082221ff55be706e162f1a15e9df3247ef7e7b

  10. real-or-random merged this on Jul 21, 2025
  11. real-or-random closed this on Jul 21, 2025

  12. fanquake referenced this in commit 5600e6fc4b on Jul 22, 2025
  13. fjahr referenced this in commit b6fc8c52d5 on Jul 24, 2025
  14. saikiran57 referenced this in commit abe11bd67c on Jul 28, 2025
  15. macgyver13 referenced this in commit ef5eeb6c13 on Aug 13, 2025
  16. janus referenced this in commit e0ffd31e87 on Sep 14, 2025
  17. vmta referenced this in commit 2b25f561a0 on Sep 21, 2025
  18. real-or-random referenced this in commit a3733f33c1 on Feb 25, 2026
  19. github-actions[bot] referenced this in commit 758d4e90b4 on Mar 1, 2026
  20. github-actions[bot] referenced this in commit 68a2178f22 on Mar 1, 2026
  21. github-actions[bot] referenced this in commit a8bc1a0b2b on Mar 1, 2026
  22. 0x000000000019d6689c085ae165831e934ff76 referenced this in commit 3b9450150d on Mar 2, 2026
  23. csjones referenced this in commit a4d92824ae on Mar 2, 2026

github-metadata-mirror

This is a metadata mirror of the GitHub repository bitcoin-core/secp256k1. This site is not affiliated with GitHub. Content is generated from a GitHub metadata backup.
generated: 2026-05-18 18:15 UTC

This site is hosted by @0xB10C
More mirrored repositories can be found on mirror.b10c.me