ecmult: Clean up integer types in _ecmult_wnaf #1795

pull real-or-random wants to merge 2 commits into bitcoin-core:master from real-or-random:202601-ecmult-wnaf-types changing 1 files +31 −29

real-or-random commented at 2:20 PM on January 7, 2026: contributor

Fixes #1769.

On top of #1794.
real-or-random added the label tweak/refactor on Jan 7, 2026
ecmult: Clean up integer types in strauss 0f75e12a90

ecmult: Fix VERIFY_CHECK to exclude UB

Left-shifting an int32_t by 31 may be signed overflow

242df7f18a

real-or-random force-pushed on Jan 7, 2026
hebasto commented at 2:49 PM on January 7, 2026: member

Concept ACK.

in src/ecmult_impl.h:164 in 0f75e12a90

 164 |      secp256k1_scalar s;
 165 | -    int last_set_bit = -1;
 166 | -    int bit = 0;
 167 | -    int sign = 1;
 168 | -    int carry = 0;
 169 | +    size_t last_set_bit = -1;

theStack commented at 2:08 PM on June 30, 2026:

nit: maybe

    size_t last_set_bit = SIZE_MAX;

(that's what we use in secp256k1_ge_set_all_gej_var, fwiw)

theStack commented at 2:09 PM on June 30, 2026: contributor

Concept ACK

Contributors

Labels

Linked (view graph)

#1769 `_ecmult_wnaf` relies on `int` being at least 32 bits #1794 ecmult: Use size_t for array indices