test: musig: fix dead "aggnonce encodes two points at infinity" check #1867

pull theStack wants to merge 1 commits into bitcoin-core:master from theStack:test-musig-actually_check_infinity changing 1 files +1 −1

theStack commented at 10:41 PM on June 9, 2026: contributor

Due to the missing CHECK around, the return values were discarded and nothing was actually checked here.

(Fwiw I prompted two AI models (MiniMax M3 and Opus 4.8) to find more similar instances in tests with bare statements that miss a surrounding CHECK in tests, and both didn't find any.)
test: musig: fix dead "aggnonce encodes two points at infinity" check d7125e517d
real-or-random added the label bug on Jun 10, 2026
real-or-random added the label assurance on Jun 10, 2026
real-or-random approved
real-or-random commented at 10:30 AM on June 10, 2026: contributor

utACK d7125e517d45507df4a3f19c8ca90393a8290480

Maybe we should use SECP256K1_WARN_UNUSED_RESULT also internally. Currently we only have this in public API functions.

Contributors

Labels