Fix #1191: Naming convention for secret function arguments #1875

pull kallal79 wants to merge 1 commits into bitcoin-core:master from kallal79:fix-issue-1191-secret-naming changing 5 files +41 −40
  1. kallal79 commented at 8:57 AM on June 18, 2026: contributor

    This PR establishes a formal, side-channel-aware naming convention for secret function arguments. It updates CONTRIBUTING.md to require the sec prefix for any function arguments processed in constant time. Relevant secret arguments in the API (like key32, nonce32, tweak32, and aux_rand32) have been renamed to seckey32, secnonce32, sectweak32, and aux_secrand32. Arguments that are intentionally not constant-time (such as public tweaks) remain unchanged, clearly distinguishing their behavior. All underlying source files, headers, and tests have been updated and fully tested to ensure no regressions.

  2. Fix #1191: Naming convention for secret function arguments 183c6520b2
Contributors

github-metadata-mirror

This is a metadata mirror of the GitHub repository bitcoin-core/secp256k1. This site is not affiliated with GitHub. Content is generated from a GitHub metadata backup.
generated: 2026-06-20 23:15 UTC

This site is hosted by @0xB10C
More mirrored repositories can be found on mirror.b10c.me