musig: fix pseudocode in `_musig_pubkey_ec_tweak_add` API docs #1909

1. 
   theStack commented at 2:25 PM on August 5, 2026: contributor

   Reported by Project Loupe

2. musig: fix pseudocode in `_musig_pubkey_ec_tweak_add` API docs 602a92f648
3. theStack added this to the milestone 0.8.1 on Aug 5, 2026
4. in include/secp256k1_musig.h:239 in 602a92f648

    235 | @@ -236,7 +236,7 @@ SECP256K1_API SECP256K1_WARN_UNUSED_RESULT int secp256k1_musig_pubkey_get(
    236 |   *
    237 |   *  secp256k1_musig_pubkey_agg(..., keyagg_cache, pubkeys, ...)
    238 |   *  secp256k1_musig_pubkey_get(..., agg_pk, keyagg_cache)
    239 | - *  secp256k1_musig_pubkey_ec_tweak_add(..., output_pk, tweak32, keyagg_cache)
   

   ---

   ---

   

   l0rinc commented at 7:41 PM on August 5, 2026:

   I also found many others a while ago: https://github.com/l0rinc/secp256k1/commit/e1cd68c630fe34bf1620c10a6e0cebf2757ef58b

   ---

   

   theStack commented at 10:55 PM on August 5, 2026:

   Nice, either that was not on one of the audit branches you showed me in the past, or (more likely) I missed it. Want to open an alternative PR with that commit?

   The exact wording of the tweak32 parameter doc change might need a closer look by reviewers (is it okay to only state "would be invalid", or do we want to keep being explicit how an invalid result is reached), but all the changes seem to make sense in principle.

5. theStack added the label user-documentation on Aug 7, 2026

Contributors

theStackl0rinc

Milestone
0.8.1