Convert field code to strict C89 (+ long long, +__int128) #193

pull gmaxwell wants to merge 2 commits into bitcoin-core:master from gmaxwell:c89_field changing 11 files +222 −186

gmaxwell commented at 5:58 AM on January 23, 2015: contributor

Convert field code to strict C89 (+ long long, +__int128)

This makes the software more portable to embedded systems and static analysis tools.

Sadly, it can't result in identical binaries because C99 mixed declarations seem to make GCC emit superfluous stack-pointer updates. The compiler is also somewhat dependent on the declaration order.

( Builds on pull req #192 )
C89 nits and dead code removal. 3627437d80

Convert field code to strict C89 (+ long long, +__int128)

This makes the software more portable to embedded systems
 and static analysis tools.

Sadly, it can't result in identical binaries because C99 mixed
 declarations seem to make GCC emit superfluous stack-pointer
 updates. The compiler is also somewhat dependent on the
 declaration order.

25b35c7ecb

sipa commented at 7:57 PM on January 24, 2015: contributor

ACK
sipa merged this on Jan 24, 2015
sipa closed this on Jan 24, 2015
sipa referenced this in commit 45cdf4479d on Jan 24, 2015
real-or-random cross-referenced this on Apr 23, 2020 from issue Improve C89 compliance by real-or-random

Contributors

gmaxwell

sipa

Linked (view graph)

#192 C89 nits and dead code removal.#746 Improve C89 compliance #1760 cmake: Add dynamic test discovery to improve parallelism