refactor: Move common nonce helpers from musig to shared module #1938

pull fjahr wants to merge 1 commits into bitcoin-core:master from fjahr:2026-09-musig-nonce-common changing 5 files +193 −83

fjahr commented at 9:49 PM on September 15, 2026: contributor

Factor the secret and public nonce (de)serialization, partial signature (de)serialization, effective nonce computation and secret clearing out of the musig module into a new nonce_common module. These helpers are not specific to musig and can be reused by other modules implementing interactive signing protocols with two-point nonces.

This came out of my work on the FullAgg/Dahlias PR which requires exactly these same helpers but since this refactoring idea can be discussed independently of the new module I am putting it here separately, as suggested by theStack.

refactor: Move common nonce helpers from musig to shared module

Factor the secret and public nonce (de)serialization, partial signature
(de)serialization, effective nonce computation and secret clearing out of
the musig module into a new nonce_common module. These helpers are not
specific to musig and can be reused by other modules implementing
interactive signing protocols with two-point nonces.

This is a pure refactor without a change in behavior.

e210f51657

Contributors

fjahr

Linked (view graph)

#1754 BIP459: Add FullAgg (DahLIAS) module