Add a BIP-352 test vector where a taproot input is spent via the key path with an annex (2-item witness). The annex must be stripped before deciding between key-path and script-path spends (see https://github.com/bitcoin/bips/blob/master/bip-0341.mediawiki#script-validation-rules), so the input is still eligible and all expected values match the plain key-path case.
tests: silentpayments: add taproot key-path spend with annex vector #1977
pull Eunovo wants to merge 1 commits into bitcoin-core:master from Eunovo:silentpayments-test-annex changing 2 files +191 −1-
Eunovo commented at 1:10 PM on October 22, 2026: none
-
077689f641
tests: silentpayments: add taproot key-path spend with annex vector
Add a BIP-352 test vector where a taproot input is spent via the key path with an annex (2-item witness). The annex must be stripped before deciding between key-path and script-path spends, so the input is still eligible and all expected values match the plain key-path case.
-
theStack commented at 1:43 AM on October 23, 2026: contributor
Thanks for adding! Since the BIPs repository (https://github.com/bitcoin/bips/blob/master/bip-0352/send_and_receive_test_vectors.json) is the source of truth for SP test vectors, could you open a PR there?
-
Eunovo commented at 7:57 AM on October 23, 2026: none
-
theStack commented at 9:34 AM on October 23, 2026: contributor
Opened bitcoin/bips#2337
Closing this one then, a new PR that syncs the test vectors with the BIPs repo can be opened once they have changed.
- theStack closed this on Oct 23, 2026