musig: declassify the keypair's pubkey in nonce_gen_counter #1979

pull fametrano wants to merge 1 commits into bitcoin-core:master from fametrano:musig-declassify-nonce-gen-counter changing 2 files +4 −0
  1. fametrano commented at 10:40 PM on October 23, 2026: contributor

    nonce_gen_counter does not declassify the pubkey it copies from the keypair, though nonce_gen_internal loads it with pubkey_load, which ARG_CHECKs it, and serializes it. keypair_load declassifies the same data for the same reason. Declassify the copy here too.

    ctime_tests passed a keypair that was never marked as secret, so it could not see this. It now marks the keypair as undefined before the call. Without the declassify, ctime_tests under valgrind reports 3 errors. With it, it reports none.

  2. musig: declassify the keypair's pubkey in nonce_gen_counter
    nonce_gen_counter does not declassify the pubkey it copies from the
    keypair, though nonce_gen_internal loads it with pubkey_load, which
    ARG_CHECKs it, and serializes it. keypair_load declassifies the same
    data for the same reason. Declassify the copy here too.
    
    ctime_tests passed a keypair that was never marked as secret, so it
    could not see this. It now marks the keypair as undefined before the
    call. Without the declassify, ctime_tests under valgrind reports 3
    errors. With it, it reports none.
    f54629328e
  3. fametrano force-pushed on Nov 2, 2026
Contributors

github-metadata-mirror

This is a metadata mirror of the GitHub repository bitcoin-core/secp256k1. This site is not affiliated with GitHub. Content is generated from a GitHub metadata backup.
generated: 2026-11-12 08:15 UTC

This site is hosted by @0xB10C
More mirrored repositories can be found on mirror.b10c.me