Include a comment on secp256k1_ecdsa_sign explaining low-s. #205

pull gmaxwell wants to merge 1 commits into bitcoin-core:master from gmaxwell:lows_comment changing 1 files +27 −1

gmaxwell commented at 2:45 AM on February 2, 2015: contributor

This was suggested by DavidEGrayson.
gmaxwell commented at 2:45 AM on February 2, 2015: contributor

@DavidEGrayson ping
Include a comment on secp256k1_ecdsa_sign explaining low-s.
This was suggested by DavidEGrayson.
6cc8425c91
DavidEGrayson commented at 2:59 AM on February 2, 2015: none

Thanks, that comment looks good to me! I am glad it talks about flipping the sign of S instead of modifying the nonce.
droark cross-referenced this on Feb 2, 2015 from issue Some comments explaining some of the constants in the code. by gmaxwell
DavidEGrayson cross-referenced this on Feb 4, 2015 from issue secp256k1_ecdsa_sign: document the low S values by DavidEGrayson
sipa commented at 1:05 AM on February 13, 2015: contributor

ACK
sipa merged this on Feb 13, 2015
sipa closed this on Feb 13, 2015
sipa referenced this in commit 122a1ecf30 on Feb 13, 2015

Contributors