C doesn't include the null in an array initilized from a string literal if it doesn't fit, in C++ this is invalid.
The vararray style prototypes and init+calc also changed in this commit are not C89 enough for some tools.
Silence some warnings from pedantic static analysis tools, improve compatibility with C++ #228
pull gmaxwell wants to merge 1 commits into bitcoin-core:master from gmaxwell:staticanalysisfixups changing 4 files +9 −5-
gmaxwell commented at 9:14 AM on March 8, 2015: contributor
-
27bc1311af
Silence some warnings from pedantic static analysis tools, improve compatibility with C++.
C doesn't include the null in an array initilized from a string literal if it doesn't fit, in C++ this is invalid. The vararray style prototypes and init+calc also changed in this commit are not C89 enough for some tools.
-
gmaxwell commented at 9:16 AM on March 8, 2015: contributor
(Sorry, wrote this in PR and seemingly never got around to PRing it; presumably because I expected to have more tool-nits like this.)
- gmaxwell cross-referenced this on Mar 8, 2015 from issue BUG: array bounds overflow by fsb4000
-
sipa commented at 10:29 AM on March 16, 2015: contributor
ACK
- sipa merged this on Mar 16, 2015
- sipa closed this on Mar 16, 2015
- sipa referenced this in commit 3087bc4d75 on Mar 16, 2015
