Add ability to pass extra entropy to rfc6979 #229

pull sipa wants to merge 2 commits into bitcoin-core:master from sipa:entrfc changing 7 files +69 −24

sipa commented at 4:20 PM on March 20, 2015: contributor

Suggested by Greg Maxwell.
gmaxwell commented at 7:01 PM on March 22, 2015: contributor

I've sent email to Thomas Pornin on the question of exactly how the 3.6 "additional data" was supposed to be applied with respect to steps 3.2.d vs 3.2.f in the draft.

I believe all solutions are likely to be adequate but for consistency I thought it would be good to clarify whats intended in the draft.
Add ability to pass extra entropy to rfc6979
Suggested by Greg Maxwell.
1573a102c0
sipa force-pushed on Mar 23, 2015
sipa commented at 1:00 PM on March 23, 2015: contributor

Updated to apply it both 3.2.d and 3.2.f.
gmaxwell commented at 12:00 PM on March 27, 2015: contributor

ACK with https://people.xiph.org/~greg/0001-Add-a-simple-testcase-for-signing-with-rfc6979-extra.patch or something substantially similar added. :)

(could you imagine if some (future) typo made the extra data blow away the other inputs to the 6979? ouch!)
Add simple testcases for signing with rfc6979 extra entropy. efc571ceea
sipa commented at 8:48 PM on March 27, 2015: contributor

Included your commit.
sipa commented at 8:49 PM on March 27, 2015: contributor

ACK extra commit.
sipa merged this on Mar 27, 2015
sipa closed this on Mar 27, 2015
sipa referenced this in commit 1897b8e90b on Mar 27, 2015

Contributors