Update configure.ac to make it build on OpenBSD #280

pull mlmikael wants to merge 1 commits into bitcoin-core:master from mlmikael:master changing 1 files +2 −0
  1. mlmikael commented at 2:08 PM on July 19, 2015: contributor

    This update is to make libsecp256k1 build on OpenBSD (more specifically OpenBSD 5.7 with Autotools 2.69).

    Without the "AM_PROG_CC_C_O" line in configure.ac, ./autogen.sh crashes with "Makefile.am: C objects in subdir but AM_PROG_CC_C_O' not inconfigure.ac'\nautoreconf-2.69: automake failed with exit status: 1".

  2. Update configure.ac to make it build on OpenBSD
    This update is to make libsecp256k1 build on OpenBSD (more specifically OpenBSD 5.7 with Autotools 2.69).
    
    Without the "AM_PROG_CC_C_O" line in configure.ac, ./autogen.sh crashes with "Makefile.am: C objects in subdir but `AM_PROG_CC_C_O' not in `configure.ac'\nautoreconf-2.69: automake failed with exit status: 1".
    ed5334a7fe
  3. sipa commented at 4:29 PM on July 19, 2015: contributor

    @theuni comments?

  4. mlmikael commented at 12:19 PM on July 22, 2015: contributor

    Further research shows that this was not an OpenBSD version problem (and not an Autotools version problem, as I understand it, also), but an Automake version problem: "AM_PROG_CC_C_O" is not required at first in Automake version 1.14, and that's a fairly recent version, and a lot of people may have older Automake versions.

    In particular, it's extremely confusing to get this error (as in the build crashes because of the absence of "AM_PROG_CC_C_O") as generally which Automake version is required is not stated overly clearly in a project and you easily get a feel that the project is broken or at least not supported on your system.

    libsecp256k1 is so much of an accessory library, that I'd say it'd be kind of odd to have particular Automake version requirements, so I'd suggest introducing the "AM_PROG_CC_C_O" line for Automake backward compatibility.

  5. theuni commented at 10:24 PM on July 22, 2015: contributor

    That macro is deprecated, but I don't see the harm in adding it if it fixes a build. Looks like worst-cast it's a nop.

  6. mlmikael commented at 10:38 PM on July 22, 2015: contributor

    Great - you can just write it as:

    Legacy, for compatibility with Automake versions prior to 1.14

    AM_PROG_CC_C_O

  7. sipa merged this on Aug 4, 2015
  8. sipa closed this on Aug 4, 2015

  9. sipa referenced this in commit 9d96e362a5 on Aug 4, 2015
Contributors

github-metadata-mirror

This is a metadata mirror of the GitHub repository bitcoin-core/secp256k1. This site is not affiliated with GitHub. Content is generated from a GitHub metadata backup.
generated: 2026-04-14 21:15 UTC

This site is hosted by @0xB10C
More mirrored repositories can be found on mirror.b10c.me