[API BREAK] Remove _t in types due to being POSIX-reserved #294

pull sipa wants to merge 1 commits into bitcoin-core:master from sipa:no_t changing 49 files +943 −943
  1. sipa commented at 12:24 AM on August 28, 2015: contributor

    Fixes #198.

    Builds on top of #293.

    Mechanical application of

    for A in include/*.h src/*.h src/*.c src/modules/*/*.h; do sed -e 's/secp256k1_\([a-z_]*\)_t\([^a-zA-Z]\)/secp256k1_\1\2/g' <$A >/tmp/bla; mv /tmp/bla $A; sed -e 's/callback_t/secp256k1_callback/g' <$A >/tmp/bla; mv /tmp/bla $A; done

  2. dcousens commented at 1:21 AM on August 28, 2015: contributor

    for A in include/.h src/.h src/.c src/modules//*.h; do sed -e <$A >/tmp/bla; mv /tmp/bla $A; sed -e <$A >/tmp/bla; mv /tmp/bla $A; done

    Seems a bit fancy, any reason to not just use -i on sed?

    sed -i 's/secp256k1_\([a-z_]*\)_t\([^a-zA-Z]\)/secp256k1_\1_type\2/g' `find include/ src/ | grep "\.\(c\|h\)$"`
    
  3. sipa commented at 1:25 AM on August 28, 2015: contributor

    @dcousens I'll use that if I need to redo it :)

  4. sipa force-pushed on Aug 29, 2015
  5. gmaxwell added this to the milestone initial release on Aug 31, 2015
  6. sipa force-pushed on Sep 4, 2015
  7. sipa commented at 6:29 PM on September 4, 2015: contributor

    Rebased.

  8. apoelstra commented at 9:00 PM on September 7, 2015: contributor

    ACK without reading the code ("only-tested ACK?"); but I ran the tests binary and benchmarks on 512 different ./configure setups with no problems.

  9. sipa force-pushed on Sep 20, 2015
  10. sipa commented at 3:02 AM on September 20, 2015: contributor

    Rebased.

  11. sipa force-pushed on Sep 21, 2015
  12. sipa commented at 6:59 PM on September 21, 2015: contributor

    As suggested by @rustyrussell: just drop the _t instead of replacing by _type.

  13. Get rid of _t as it is POSIX reserved dd891e0ed5
  14. sipa force-pushed on Sep 21, 2015
  15. sipa renamed this:
    [API BREAK] Change _t to _type due to being POSIX-reserved
    [API BREAK] Remove _t in types due to being POSIX-reserved
    on Sep 21, 2015
  16. gmaxwell commented at 6:24 PM on September 22, 2015: contributor

    ACK

  17. sipa merged this on Sep 22, 2015
  18. sipa closed this on Sep 22, 2015

  19. sipa referenced this in commit 9e9051687c on Sep 22, 2015

github-metadata-mirror

This is a metadata mirror of the GitHub repository bitcoin-core/secp256k1. This site is not affiliated with GitHub. Content is generated from a GitHub metadata backup.
generated: 2026-04-14 11:15 UTC

This site is hosted by @0xB10C
More mirrored repositories can be found on mirror.b10c.me