Bad callback logic #300

1. 
   theuni commented at 6:05 PM on September 1, 2015: contributor

   Given that ARG_CHECK is defined as:

   #define ARG_CHECK(cond) do { \
       if (EXPECT(!(cond), 0)) { \
           ctx->illegal_callback.fn(#cond, ctx->illegal_callback.data); \
           return 0; \
       } \
   } while(0)
   

   These checks (17 of 'em from a quick grep) make no sense and are doomed to explode:

   ARG_CHECK(ctx != NULL);
   

2. 
   gmaxwell commented at 6:14 PM on September 1, 2015: contributor

   Haha.

3. theuni cross-referenced this on Sep 1, 2015 from issue bugfix: don't blow up on "ARG_CHECK(ctx != NULL)" by theuni
4. 
   sipa commented at 7:06 PM on September 1, 2015: contributor

   Good catch!

5. theuni cross-referenced this on Sep 3, 2015 from issue remove unused assignment by theuni
6. gmaxwell added this to the milestone initial release on Sep 17, 2015
7. 
   sipa commented at 11:07 PM on September 29, 2015: contributor

   Fixed by #301

8. sipa closed this on Sep 29, 2015

   ---

Contributors

theunigmaxwellsipa

Milestone
stable release (1.0.0-rc.1)