Add some missing `VERIFY_CHECK(ctx != NULL)` #386

pull apoelstra wants to merge 1 commits into bitcoin-core:master from apoelstra:arg-check changing 1 files +4 −9

apoelstra commented at 3:52 PM on April 26, 2016: contributor

The ARG_CHECK macro requires that a variable called ctx exist and be non-NULL. However, in several functions that do not use the context variable, we simply ignore it with (void)ctx. Replace these with explicit checks for non-NULLness to avoid invalid memory accesses.

Add some missing `VERIFY_CHECK(ctx != NULL)` for functions that use `ARG_CHECK`

The `ARG_CHECK` macro requires that a variable called `ctx` exist and be
non-NULL. However, in several functions that do not use the context variable,
we simply ignore it with `(void)ctx`. Replace these with explicit checks for
non-NULLness to avoid invalid memory accesses.

bcc4881d3a

sipa commented at 6:02 PM on May 8, 2016: contributor

utACK
sipa merged this on May 8, 2016
sipa closed this on May 8, 2016
sipa referenced this in commit 6875b013e6 on May 8, 2016
apoelstra deleted the branch on Jun 19, 2017

Contributors

apoelstra

sipa