A couple minor cleanups #400

pull apoelstra wants to merge 2 commits into bitcoin-core:master from apoelstra:cleanup changing 5 files +1 −8

apoelstra commented at 4:05 PM on June 6, 2016: contributor

No description provided.
gmaxwell commented at 4:17 PM on June 6, 2016: contributor

on the non-null checks, something is wrong-- the build setup should not be compiling libsecp256k1 itself with the non-null prototype annotation, as that will make GCC optimize out any form of nullness check.
apoelstra commented at 4:21 PM on June 6, 2016: contributor

Hmm, I started seeing this warning since upgrading my system to a recent Arch build. gcc (GCC) 6.1.1 20160501.
apoelstra force-pushed on Jun 6, 2016
apoelstra commented at 8:00 PM on June 6, 2016: contributor

As per IRC conversation, changed the -Wno-nonnull commit to instead add -DSECP256K1_BUILD to the benchmark builds, since that was the actual problem.
sipa commented at 9:14 AM on June 29, 2016: contributor

I don't think -DSECP256K1_BUILD should be used for the verify and sign benchmarks, as those don't build the internal code, but link against the library. Only the internal benchmarks build the internal code.
Remove a bunch of unused stdlib #includes a6c6f994b5

build: add -DSECP256K1_BUILD to benchmark_internal build flags

gcc 6 will warn about our non-null checks when SECP256K1_BUILD
our NONNULL marker is nontrivial. This occurs unless SECP256K1_BUILD
is set, which we had forgotten to do for the internal benchmarks,
which compile directly against the library instead of linking.

ac01378c87

apoelstra force-pushed on Jul 6, 2016
sipa commented at 12:07 PM on July 6, 2016: contributor

ACK
sipa merged this on Jul 6, 2016
sipa closed this on Jul 6, 2016
sipa referenced this in commit 5a91bd768f on Jul 6, 2016
apoelstra deleted the branch on Jun 19, 2017

Contributors

apoelstra

gmaxwell

sipa