Remove guarantees about memcmp-ability #411

pull apoelstra wants to merge 1 commits into bitcoin-core:master from apoelstra:no-guarantees changing 1 files +4 −10
  1. apoelstra commented at 6:06 PM on August 26, 2016: contributor

    We had a discussion in person some months ago about the guarantees on the representation of the publicly exposed types, and I think guaranteeing memcmp is too strong. There are lots of internal things that can't be memcmp'd and it stands to reason that we might want the freedom to use similar representations for public types in future.

    Note that removing this guarantee makes comparison of points that might be infinity quite annoying.

  2. Remove guarantees about memcmp-ability 91219a1cc0
  3. sipa commented at 8:19 PM on August 26, 2016: contributor

    ACK.

    If there is demand we may need to add _compare functions to avoid a roundtrip to the serializer to test equality, but I don't think that's needed yet.

  4. sipa merged this on Oct 26, 2016
  5. sipa closed this on Oct 26, 2016

  6. sipa referenced this in commit 6e066962b7 on Oct 26, 2016
  7. apoelstra deleted the branch on Jun 19, 2017
Contributors

github-metadata-mirror

This is a metadata mirror of the GitHub repository bitcoin-core/secp256k1. This site is not affiliated with GitHub. Content is generated from a GitHub metadata backup.
generated: 2026-04-22 20:15 UTC

This site is hosted by @0xB10C
More mirrored repositories can be found on mirror.b10c.me