assign zero value to overflow before secp256k1_scalar_set_b32 doesn't make sense
Remove useless code in secp256k1_schnorr_sig_recover #417
pull fanatid wants to merge 1 commits into bitcoin-core:master from fanatid:schnorr-recover changing 1 files +0 −2-
fanatid commented at 9:11 AM on September 14, 2016: contributor
-
Remove useless code in secp256k1_schnorr_sig_recover a41a9cd3ea
-
apoelstra commented at 7:22 PM on September 15, 2016: contributor
I think some lint tool complained about passing the address of uninitialized variables. Unfortunately C doesn't have any way to signal out-parameters.
I'd prefer the useless code stay, just as a matter of "defense in depth" coding practice of not passing addresses of unitiliazed variables.
-
sipa commented at 8:35 PM on November 25, 2016: contributor
No longer needed.
- sipa closed this on Nov 25, 2016
- fanatid deleted the branch on Jan 7, 2017
