Increase test coverage and add a configure flag to ease coverage analysis #426

pull apoelstra wants to merge 5 commits into bitcoin-core:master from apoelstra:coverage changing 11 files +207 −28

apoelstra commented at 8:35 PM on November 26, 2016: contributor

No description provided.

ecdsa_impl: replace scalar if-checks with VERIFY_CHECKs in ecdsa_sig_sign

Whenever ecdsa_sig_sign is called, in the case that r == 0 or r overflows,
we want to retry with a different nonce rather than fail signing entirely.
Because of this, we always check the nonce conditions before calling
sig_sign, so these checks should always pass (and in particular, they
are inaccessible through the API and appear as uncovered code in test
coverage).

25e3cfbf9b

ecdh: test NULL-checking of arguments
Boosts the ECDH module to 100% coverage
6f8ae2f3c0
apoelstra force-pushed on Nov 26, 2016
apoelstra force-pushed on Nov 26, 2016
apoelstra force-pushed on Nov 26, 2016
recovery: add tests to cover API misusage b595163992
configure: add --enable-coverage to set options for coverage analysis a724d7296d

group_impl.h: remove unused `secp256k1_ge_set_infinity` function

Also remove `secp256k1_fe_verify` from field_*_.impl.h when VERIFY is not defined

03ff8c2d0a

apoelstra force-pushed on Nov 28, 2016
apoelstra commented at 3:30 AM on November 28, 2016: contributor

Reduced iterations of recovery API tests from 64 * count to just count; stopped leaking four contexts' worth of memory on every one of these iterations.

Travis should be happier now :)
apoelstra cross-referenced this on Nov 28, 2016 from issue Exhaustive recovery by apoelstra
gmaxwell commented at 10:10 PM on December 16, 2016: contributor

ACK.
sipa merged this on Dec 28, 2016
sipa closed this on Dec 28, 2016
real-or-random cross-referenced this on Mar 24, 2022 from issue Initial gcov work by cbatson

Contributors

apoelstra

gmaxwell

Linked (view graph)

#219 Initial gcov work #428 Exhaustive recovery