secp256k1_context_randomize: document. #441

pull rustyrussell wants to merge 2 commits into bitcoin-core:master from rustyrussell:document-secp256k1_context_randomize changing 1 files +16 −1

rustyrussell commented at 5:05 AM on February 14, 2017: contributor

I prefer the idea of adding a randseed32 arg to create() and clone() (as well as leaving this here for reseeding), but if we're API stable that is a bigger change...

secp256k1_context_randomize: document.

I think I summarized it correctly after IRC discussion with gmaxwell
and andytoshi; I didn't know it existed :(

It's regrettable to expose this level of detail, but users need to know
this to make a decision about how to use it.

Signed-off-by: Rusty Russell <rusty@rustcorp.com.au>

70ff29b6a7

in include/secp256k1.h:None in 70ff29b6a7 outdated

 556 | + * values are, it's possible that a future compiler may output code which isn't,
 557 | + * and also that the CPU may not emit the same radio frequencies or draw the same
 558 | + * amount power for all values.
 559 | + *
 560 | + * This function provides a seed which is combined into the blinding value: that
 561 | + * blinding value added before each multiplication (and removed afterwards) so

sipa commented at 8:58 AM on February 17, 2017:

missing is after value?

FIXUP: Missing "is"

Signed-off-by: Rusty Russell <rusty@rustcorp.com.au>

72d952c9c4

sipa commented at 12:35 AM on March 22, 2017: contributor

ACK
sipa merged this on Mar 22, 2017
sipa closed this on Mar 22, 2017
sipa referenced this in commit 6af0871070 on Mar 22, 2017

Contributors

rustyrussell

sipa