Don't fail JNI dependency checks if we can build a JNI program #466

pull jgriffiths wants to merge 1 commits into bitcoin-core:master from jgriffiths:jni_fix changing 1 files +3 −0

jgriffiths commented at 5:50 AM on July 10, 2017: contributor

Not all setups will result in JNI_INCLUDE_DIRS having a value, in particular Android builds from standalone toolchain directories have the JNI headers installed in the standard include directories.

Instead of failing if the configure macro didn't find a directory based on the installed Java runtime, only fail if we cannot build a JNI-including program.

Don't fail JNI dependency checks if we can build a JNI program

Not all setups will result in JNI_INCLUDE_DIRS having a value, in
particular Android builds from standalone toolchain directories have
the JNI headers installed in the standard include directories.

Instead of failing if the configure macro didn't find a directory
based on the installed Java runtime, only fail if we cannot build a
JNI-including program.

6af61c832d

gmaxwell approved
gmaxwell commented at 1:23 AM on July 11, 2017: contributor

Looks good to me. utACK
sipa commented at 7:38 AM on July 31, 2017: contributor

@theuni Care to have a look?
theuni commented at 3:18 PM on August 8, 2017: contributor

This can re-enable jni if it's been turned off because ecdh is disabled. I think the quick fix is just to move the enable_module_ecdh check down a bit.
real-or-random cross-referenced this on Jan 7, 2020 from issue Remove Java Native Interface by jonasnick
real-or-random commented at 11:12 AM on February 10, 2020: contributor

Closing this because we removed the JNI bindings in #682.
real-or-random closed this on Feb 10, 2020

Contributors

Linked (view graph)

#682 Remove Java Native Interface