Remove dead store in secp256k1_ecmult_gen. #485

pull BitonicEelis wants to merge 1 commits into bitcoin-core:master from BitonicEelis:deadstore changing 1 files +1 −3

BitonicEelis commented at 3:13 PM on November 9, 2017: none
This fixes the following clang-analyzer warning:
```
src/ecmult_gen_impl.h:153:5: warning: Value stored to 'bits' is never read
```
Remove dead store in secp256k1_ecmult_gen. 0279786adc
sipa commented at 10:33 PM on December 21, 2017: contributor

utACK 0279786adc8132874a2e62e3026584248090f47e
gmaxwell commented at 10:01 PM on February 3, 2018: contributor

These assignments of variables holding secret data should be replaced with explicit zeroization, not just removed. Existing code is a placeholder for that.
fanquake cross-referenced this on Apr 12, 2018 from issue 979f598: Clang Static Analyzer Report by kallewoof
awemany referenced this in commit 250f22e163 on Jul 12, 2018
awemany referenced this in commit 318f55ad59 on Jul 14, 2018
awemany referenced this in commit a3146ca537 on Jul 14, 2018
DesWurstes cross-referenced this on Mar 22, 2019 from issue Remove all Clang Static Analyzer warnings (except one) by DesWurstes
practicalswift commented at 2:17 PM on March 22, 2019: contributor

utACK 0279786adc8132874a2e62e3026584248090f47e
sipa commented at 11:03 PM on April 1, 2019: contributor

Agree with @gmaxwell; we should instead replace it with explicit wiping.
BitonicEelis commented at 11:44 AM on April 8, 2019: none

Roger that, closing this PR then. Thanks for the review!
BitonicEelis closed this on Apr 8, 2019

Contributors