bench_recover and bench_ecdh do not build #526

issue deadalnix opened this issue on April 6, 2018
  1. deadalnix commented at 10:22 PM on April 6, 2018: none

    Repro steps for the recovery module (ecdh is similar)

    $ ./configure --enable-benchmark --enable-module-recovery
    $ make
    gcc -I. -g -O2 -Wall -Wextra -Wno-unused-function -c src/gen_context.c -o gen_context.o
    gcc gen_context.o -o gen_context
    ./gen_context
      CC       src/libsecp256k1_la-secp256k1.lo
      CCLD     libsecp256k1.la
    /usr/bin/ar: `u' modifier ignored since `D' is the default (see `U')
      CC       src/bench_verify.o
      CCLD     bench_verify
      CC       src/bench_sign.o
      CCLD     bench_sign
      CC       src/bench_internal-bench_internal.o
      CCLD     bench_internal
      CC       src/bench_ecmult-bench_ecmult.o
      CCLD     bench_ecmult
      CC       src/tests-tests.o
      CCLD     tests
      CC       src/exhaustive_tests-tests_exhaustive.o
      CCLD     exhaustive_tests
      CC       src/bench_recover.o
    src/bench_recover.c:18:6: error: ‘bench_recover’ redeclared as different kind of symbol
     void bench_recover(void* arg) {
          ^~~~~~~~~~~~~
    src/bench_recover.c:16:3: note: previous declaration of ‘bench_recover’ was here
     } bench_recover;
    [...]
    Makefile:1009: recipe for target 'src/bench_recover.o' failed
    make: *** [src/bench_recover.o] Error 1
    
  2. apoelstra commented at 10:24 PM on April 6, 2018: contributor

    What commit are you running? I cannot reproduce this.

  3. apoelstra commented at 10:25 PM on April 6, 2018: contributor

    I think you may be encountering the issue fixed in https://github.com/bitcoin-core/secp256k1/pull/490

  4. deadalnix commented at 10:28 PM on April 6, 2018: none

    Absolutely. Then it's already fixed. Thanks and sorry for the inconvenience.

  5. deadalnix closed this on Apr 6, 2018


github-metadata-mirror

This is a metadata mirror of the GitHub repository bitcoin-core/secp256k1. This site is not affiliated with GitHub. Content is generated from a GitHub metadata backup.
generated: 2026-04-14 15:15 UTC

This site is hosted by @0xB10C
More mirrored repositories can be found on mirror.b10c.me