Make constants static: #552

pull roconnor-blockstream wants to merge 1 commits into bitcoin-core:master from roconnor-blockstream:CURVE_B changing 1 files +5 −5

roconnor-blockstream commented at 7:50 PM on August 15, 2018: contributor

static const secp256k1_ge secp256k1_ge_const_g; static const int CURVE_B;

Make constants static:

static const secp256k1_ge secp256k1_ge_const_g;
static const int CURVE_B;

496c5b43b8

DesWurstes commented at 9:55 AM on August 30, 2018: contributor

I've verified that after this Pull Request gets merged, no symbols that shouldn't be exported can be accessed from outside.

$ nm -g ./libsecp256k1_la-secp256k1.o 
000000000001f480 S _CURVE_B
                 U ___gmpn_gcdext
                 U ___gmpn_get_str
                 U ___gmpn_set_str
                 U ___gmpn_sub_n
                 U ___memset_chk
                 U ___stderrp
                 U _abort
                 U _fprintf
                 U _free
                 U _malloc
                 U _memcpy
                 U _memset
000000000000b550 T _secp256k1_context_clone
000000000000aea0 T _secp256k1_context_create
000000000000b710 T _secp256k1_context_destroy
000000000000ec40 T _secp256k1_context_randomize
000000000000b760 T _secp256k1_context_set_error_callback
000000000000b740 T _secp256k1_context_set_illegal_callback
000000000000dd40 T _secp256k1_ec_privkey_negate
000000000000e0d0 T _secp256k1_ec_privkey_tweak_add
000000000000e740 T _secp256k1_ec_privkey_tweak_mul
000000000000ec90 T _secp256k1_ec_pubkey_combine
000000000000d850 T _secp256k1_ec_pubkey_create
000000000000de60 T _secp256k1_ec_pubkey_negate
000000000000b810 T _secp256k1_ec_pubkey_parse
000000000000c530 T _secp256k1_ec_pubkey_serialize
000000000000e380 T _secp256k1_ec_pubkey_tweak_add
000000000000e890 T _secp256k1_ec_pubkey_tweak_mul
000000000000d7e0 T _secp256k1_ec_seckey_verify
000000000000d150 T _secp256k1_ecdsa_sign
000000000000cd90 T _secp256k1_ecdsa_signature_normalize
000000000000c830 T _secp256k1_ecdsa_signature_parse_compact
000000000000c6f0 T _secp256k1_ecdsa_signature_parse_der
000000000000ccd0 T _secp256k1_ecdsa_signature_serialize_compact
000000000000c950 T _secp256k1_ecdsa_signature_serialize_der
000000000000cf70 T _secp256k1_ecdsa_verify
000000000001f4f8 S _secp256k1_nonce_function_default
000000000001f500 S _secp256k1_nonce_function_rfc6979
000000000000b780 T _secp256k1_scratch_space_create
000000000000b7f0 T _secp256k1_scratch_space_destroy

gmaxwell commented at 2:52 AM on September 4, 2018: contributor

ACK
gmaxwell merged this on Feb 21, 2019
gmaxwell closed this on Feb 21, 2019
gmaxwell referenced this in commit 2ebdad772a on Feb 21, 2019

Contributors

roconnor-blockstream

DesWurstes

gmaxwell