This results in more self-documenting code.
Constants defined here: https://github.com/bitcoin-core/secp256k1/blob/1e6f1f5ad5e7f1e3ef79313ec02023902bf8175c/include/secp256k1.h#L175-L180
Make use of TAG_PUBKEY constants in secp256k1_eckey_pubkey_parse #562
pull Empact wants to merge 1 commits into bitcoin-core:master from Empact:pubkey-tag changing 1 files +1 −1-
Empact commented at 6:44 AM on October 9, 2018: contributor
-
d3cb1f95eb
Make use of TAG_PUBKEY constants in secp256k1_eckey_pubkey_parse
This results in more self-documenting code.
-
gmaxwell commented at 5:32 AM on February 21, 2019: contributor
Meh. I've never been a fan of replacing simple immediate (near-)single use immutable values with construction-opaque macros. But doing this here makes the code more consistent, so I will defer to the judgement that went into using EVEN and ODD in the surrounding code previously and ACK. I reserve the right to whine about the conversion of other simple constants elsewhere. :P
- gmaxwell merged this on Feb 21, 2019
- gmaxwell closed this on Feb 21, 2019
- gmaxwell referenced this in commit 870a977644 on Feb 21, 2019
- Empact deleted the branch on Feb 21, 2019
