Only use the libcrypto part of OpenSSL #58

pull sipa wants to merge 1 commits into bitcoin-core:master from sipa:nolibssl changing 1 files +3 −8
  1. sipa commented at 5:46 PM on September 1, 2014: contributor

    We shouldn't be needing libssl at all; all functions we use are in libcrypto.

  2. Only use the libcrypto part of OpenSSL 3ed6dfae69
  3. sipa commented at 5:46 PM on September 1, 2014: contributor

    @theuni Care to review?

  4. theuni commented at 6:41 PM on September 1, 2014: contributor

    @sipa: Hmm, I thought I tested this when doing the autotools stuff and openssl was necessary for some reason. Looking.

  5. sipa commented at 6:57 PM on September 1, 2014: contributor

    openssl = libssl + libcrypto. We only use things from libcrypto.

  6. theuni commented at 7:20 PM on September 1, 2014: contributor

    @sipa Looks like I was thrown off at the time by the fact that libcrypto installs headers under openssl/, so I assumed that they may be dependent on some openssl headers (global build config headers, for ex) as a result.

    I've tried building and installing libcrypto without libssl to no avail, and distros don't attempt to split them up either. So it seems there's no risk of missing any parent headers. ACK on the change.

    Worth renaming the config switch while it's still early to --with-bignum=libcrypto ?

  7. sipa commented at 7:44 PM on September 1, 2014: contributor

    @theuni I think libcrypto is less clear than openssl, and as they're inseparable as part of that system, there is little difference anyway.

  8. sipa commented at 7:53 PM on September 1, 2014: contributor

    @theuni It's the other way around btw: libssl (high level ssl implementation) depends on libcrypto (low level crypto routines).

  9. theuni commented at 8:03 PM on September 1, 2014: contributor

    @sipa sounds good. As for the split, I realize that libssl depends on libcrypto. However, that's not to say that libcrypto doesn't end up sharing some global config headers from the parent project.

    For ex, bitcoin's crypto/* files depend on bitcoin-config.h to determine what features it can use. Similarly, libcrypto relies on openssl/opensslconf.h (openssl/crypto.h -> openssl/e_os2.h -> openssl/opensslconf.h). But they're inseparable anyway, so that's no concern to us.

  10. sipa merged this on Sep 1, 2014
  11. sipa closed this on Sep 1, 2014

  12. sipa referenced this in commit f023dc53c4 on Sep 1, 2014
  13. ysangkok referenced this in commit 11af7015de on Mar 19, 2020
Contributors

github-metadata-mirror

This is a metadata mirror of the GitHub repository bitcoin-core/secp256k1. This site is not affiliated with GitHub. Content is generated from a GitHub metadata backup.
generated: 2026-04-14 11:15 UTC

This site is hosted by @0xB10C
More mirrored repositories can be found on mirror.b10c.me