No description provided.
JNI: fix use sig array #583
pull fingera wants to merge 1 commits into bitcoin-core:master from fingera:fix-typo changing 1 files +3 −3-
fingera commented at 8:48 AM on December 26, 2018: contributor
-
fingera commented at 2:40 AM on December 27, 2018: contributor
-
gmaxwell commented at 9:32 PM on January 1, 2019: contributor
I hate it when I accidentally press the [72] key.
This change looks fine, but please don't make inaccurate commit messages.
-
JNI: fix use sig array 74e2dbd68e
- fingera force-pushed on Jan 3, 2019
- fingera renamed this:
fix typo
JNI: fix use sig array
on Jan 3, 2019 -
gmaxwell commented at 5:24 AM on February 21, 2019: contributor
Thanks for the update. Sorry for the slow response. While you're fixing this, can you also change the code to make use of the return values and not just silence ignoring them?
-
sipa commented at 6:55 PM on July 23, 2019: contributor
ACK 74e2dbd68e07f752ac326a578e3071f9efa55e55. This is clearly an improvement.
Feel free to address to comment, but the serialization should never fail as the output array is large enough for any ECDSA signature.
-
real-or-random commented at 9:53 PM on July 23, 2019: contributor
ACK 74e2dbd68e07f752ac326a578e3071f9efa55e55 I've read the code but haven't tested it
- sipa merged this on Aug 6, 2019
- sipa closed this on Aug 6, 2019
- sipa referenced this in commit 786dfb49f5 on Aug 6, 2019
- sipa cross-referenced this on Jun 9, 2020 from issue Update libsecp256k1 subtree by sipa
- fanquake referenced this in commit 8c97780db8 on Jun 13, 2020
- sidhujag referenced this in commit 8a3a072968 on Jun 13, 2020
- ComputerCraftr referenced this in commit b98f1c6e6c on Jun 16, 2020
- UdjinM6 referenced this in commit 9d36ba6570 on Aug 10, 2021
- 5tefan referenced this in commit 8ded2caa74 on Aug 12, 2021
- gades referenced this in commit d855cc511d on May 8, 2022
Contributors