Pass scalar by reference in secp256k1_wnaf_const() #617

pull real-or-random wants to merge 1 commits into bitcoin-core:master from real-or-random:pass-by-ref changing 3 files +13 −13

real-or-random commented at 9:48 AM on May 14, 2019: contributor

After this change, no struct or union is passed by value in the entire codebase. This makes it easier to compile the library with CompCert.

Pass scalar by reference in secp256k1_wnaf_const()

After this change, no struct or union is passed by value in the
entire codebase. This makes it easier to compile the library with
CompCert.

8979ec0d9a

gmaxwell commented at 10:05 AM on May 14, 2019: contributor

Concept ACK
sipa commented at 4:09 AM on May 22, 2019: contributor

Concept ACK
gmaxwell commented at 4:39 AM on May 22, 2019: contributor

ACK. Benchmarks slightly but consistently faster for me too.
gmaxwell merged this on May 22, 2019
gmaxwell closed this on May 22, 2019
gmaxwell referenced this in commit 975e51e0d9 on May 22, 2019
sipa cross-referenced this on Jun 9, 2020 from issue Update libsecp256k1 subtree by sipa
fanquake referenced this in commit 8c97780db8 on Jun 13, 2020
sidhujag referenced this in commit 8a3a072968 on Jun 13, 2020
ComputerCraftr referenced this in commit b98f1c6e6c on Jun 16, 2020
UdjinM6 referenced this in commit 9d36ba6570 on Aug 10, 2021
5tefan referenced this in commit 8ded2caa74 on Aug 12, 2021
gades referenced this in commit d855cc511d on May 8, 2022

Contributors