Avoid generate duplicated files for install command. #625

pull doitian wants to merge 1 commits into bitcoin-core:master from doitian:fix-installing-duplicated-headers changing 2 files +0 −2

doitian commented at 12:20 AM on May 24, 2019: contributor

The module headers are already added in the top Makefile.am, which is introduced in 91fae3ace0291b144b27fd8bbda509042f5400f1, but the module Makefile.am.include will add the headers again.

Steps to reproduce the issue:

./autogen.sh
./configure --enable-module-recovery --prefix /tmp/secp256k1
make
make install

Failure message:

/usr/bin/install -c -m 644 include/secp256k1.h include/secp256k1_ecdh.h include/secp256k1_recovery.h include/secp256k1_recovery.h '/usr/local/include'
/usr/bin/install: will not overwrite just-created '/usr/local/include/secp256k1_recovery.h' with 'include/secp256k1_recovery.h'
Makefile:1151: recipe for target 'install-includeHEADERS' failed
make[1]: *** [install-includeHEADERS] Error 1
make[1]: Leaving directory '/home/travis/secp256k1'
Makefile:1578: recipe for target 'install-am' failed
make: *** [install-am] Error 2

Closes https://github.com/bitcoin-core/secp256k1/issues/624

Avoid generate duplicated files for install command.

The module headers are already added in the top `Makefile.am`, which is
introduced in 91fae3ace0291b144b27fd8bbda509042f5400f1, but the module
`Makefile.am.include` will add the headers again.

Steps to reproduce the issue:

    ./autogen.sh
    ./configure --enable-module-recovery --prefix /tmp/secp256k1
    make
    make install

Failure message:

    /usr/bin/install -c -m 644 include/secp256k1.h include/secp256k1_ecdh.h include/secp256k1_recovery.h include/secp256k1_recovery.h '/usr/local/include'
    /usr/bin/install: will not overwrite just-created '/usr/local/include/secp256k1_recovery.h' with 'include/secp256k1_recovery.h'
    Makefile:1151: recipe for target 'install-includeHEADERS' failed
    make[1]: *** [install-includeHEADERS] Error 1
    make[1]: Leaving directory '/home/travis/secp256k1'
    Makefile:1578: recipe for target 'install-am' failed
    make: *** [install-am] Error 2

Closes https://github.com/bitcoin-core/secp256k1/issues/624

447d362939

gmaxwell commented at 12:32 AM on May 24, 2019: contributor

Drat. AFAICT simply reverting the merge is actually the correct fix. Do you agree? If so I would appreciate changing your PR to just a revert.
doitian referenced this in commit 662918cb29 on May 24, 2019
doitian cross-referenced this on May 24, 2019 from issue Revert "Merge #620: Install headers automatically" by doitian
doitian commented at 12:38 AM on May 24, 2019: contributor

Drat. AFAICT simply reverting the merge is actually the correct fix. Do you agree? If so I would appreciate changing your PR to just a revert.

I created another one to do the revert. Pick one and close the other.
gmaxwell referenced this in commit 1a02d6ce51 on May 24, 2019
gmaxwell commented at 1:01 AM on May 24, 2019: contributor

Resolved by #626
gmaxwell closed this on May 24, 2019

Contributors

doitian

gmaxwell

Linked (view graph)

#624 `make install` fails #626 Revert "Merge #620: Install headers automatically"